Conversation
This reverts commit bc8f649.
|
Can one of the admins verify this patch? |
|
Hi @dihan0604, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
TTYL, AZPRBOT; |
|
Please fix the tests and add coverage for the new operations. |
|
Hi Denis, Thanks |
There was a problem hiding this comment.
Why is this version changed? Did you make any changes to the Network libraries?
|
We added some new API in Network libraries. |
|
Hi @dihan0604 I don't see any network library changes here, is there anything I'm missing? |
|
LGTM |
|
Have addressed the comment, please merge it. I updated the express route version and revert the one for network |
|
@azuresdkci retest this please |
|
The master branch is failing due to another merged bad pull request. Should be fixed in a bit. |
|
@dihan0604, please fetch latest master and merge, so to trigger CI run. We have reverted problematic PRs to clean up the current master branch |
…erations do not throw standard exceptions, but return ErrorResponses with more information (PR Azure#1614).
…Action Groups API, and fixing some documentation typos (from Swagger) (#3646) * Adding ActivityLogAlerts and ActionGroups API calls, PATH operations, and the corresponding unit tests * Generating code from the 'current' branch of the Swagger specs repo * Adding scenario tests * Improving scenario tests and re-recording them * Making sure the scenario tests point to the more recent version of the Resource Manager dll. Enabling tests for netcoreapp1.1 * Introducing multidimensional metrics API and removing the previous one. * Reverting netcoreapp1.1 test target since it fails to find the records. * Returning generate.md to its Azure\psSdkJson6 state * Re-enabling tests for netcoreapp1.1 * [Monitor] Adding multi-dim metrics API and making sure ActionGroupsOperations do not throw standard exceptions, but return ErrorResponses with more information (PR #1614). * [Monitor] Fixing documentation typos (from Swagger). Improving the error response for Action Groups API.
…Action Groups API, and fixing some documentation typos (from Swagger) (Azure#3646) * Adding ActivityLogAlerts and ActionGroups API calls, PATH operations, and the corresponding unit tests * Generating code from the 'current' branch of the Swagger specs repo * Adding scenario tests * Improving scenario tests and re-recording them * Making sure the scenario tests point to the more recent version of the Resource Manager dll. Enabling tests for netcoreapp1.1 * Introducing multidimensional metrics API and removing the previous one. * Reverting netcoreapp1.1 test target since it fails to find the records. * Returning generate.md to its Azure\psSdkJson6 state * Re-enabling tests for netcoreapp1.1 * [Monitor] Adding multi-dim metrics API and making sure ActionGroupsOperations do not throw standard exceptions, but return ErrorResponses with more information (PR Azure#1614). * [Monitor] Fixing documentation typos (from Swagger). Improving the error response for Action Groups API.
7 participants
No description provided.