[Monitor] Adding proper error response behavior to the Action Groups API. Fixing documentation typos in the Activity Log Alerts and Action Groups APIs.#1622
Merged
sergey-shandar merged 12 commits intoAzure:currentfrom Sep 1, 2017
Conversation
…ng issue Azure#1475: incorrect example in LogProfiles API documentation for CreateOrUpdate, fixing incorrect logProfiles example names.
…API. Fixing documentation typos in the Activity Log Alerts and Action Groups APIs.
Contributor
Author
|
Hi There, I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result: File: AutoRest Linter Guidelines | AutoRest Linter Issues Send feedback and make AutoRest Linter Azure Bot smarter day by day! Thanks for your co-operation. |
sergey-shandar
approved these changes
Sep 1, 2017
Contributor
sergey-shandar
left a comment
There was a problem hiding this comment.
LGTM. Only error messages and error structure is added.
|
No modification for AutorestCI/azure-sdk-for-node |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger