Skip to content

[Monitor] Adding proper error response behavior to the Action Groups API. Fixing documentation typos in the Activity Log Alerts and Action Groups APIs.#1622

Merged
sergey-shandar merged 12 commits intoAzure:currentfrom
AuxMon:AGErrorsAndTypo
Sep 1, 2017
Merged

[Monitor] Adding proper error response behavior to the Action Groups API. Fixing documentation typos in the Activity Log Alerts and Action Groups APIs.#1622
sergey-shandar merged 12 commits intoAzure:currentfrom
AuxMon:AGErrorsAndTypo

Conversation

@gucalder
Copy link
Copy Markdown
Contributor

@gucalder gucalder commented Aug 31, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@gucalder
Copy link
Copy Markdown
Contributor Author

Second part of the, now closed, PR #1614. This part includes only changes to resource-manager.
First part is PR #1620.

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/resource-manager/readme.md
Before the PR: Warning(s): 23 Error(s): 10
After the PR: Warning(s): 23 Error(s): 10

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

Copy link
Copy Markdown
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only error messages and error structure is added.

@sergey-shandar sergey-shandar merged commit 3904406 into Azure:current Sep 1, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

@gucalder gucalder deleted the AGErrorsAndTypo branch September 1, 2017 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants