New diagnostic settings operation with multi setting support#3636
Closed
vcanaa wants to merge 14 commits intoAzure:psSdkJson6from
Closed
New diagnostic settings operation with multi setting support#3636vcanaa wants to merge 14 commits intoAzure:psSdkJson6from
vcanaa wants to merge 14 commits intoAzure:psSdkJson6from
Conversation
… and the corresponding unit tests
… into psSdkJson6 # Conflicts: # src/SDKs/Monitor/Management.Monitor/generate.cmd
…e Resource Manager dll. Enabling tests for netcoreapp1.1
gucalder
suggested changes
Aug 30, 2017
Contributor
gucalder
left a comment
gucalder
left a comment
There was a problem hiding this comment.
Please update the AssemblyInfo.cs file for the Microsoft.Azure.Management.Monitor project, increase the version to 0.17.0.0.
That will make it compatible with my new version for multi-dim metrics if both PRs are merged before the Ignite deadline.
gucalder
reviewed
Aug 30, 2017
Contributor
gucalder
left a comment
gucalder
left a comment
There was a problem hiding this comment.
The failure in one scenario tests is not happening in the local execution (using recorded files.)
In any, case the failure has nothing to do with this change.
8 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renaming the ServiceDiagnosticSettings operation to DiagnosticSettings operation and adding more functionality.
The new command will be backward compatible with the existing api /diagnosticSettings/service and will also works with /diagnosticSettings/{name}, where a generic name can be passed in.
Renaming ServiceBusRuleId to EventHubAuthorizationRuleId.
Accepting EventHubName to be defined
Adding List operation to diagnostic settings.
Adding operations to list diagnostic settings categories.
Azure/azure-rest-api-specs#1613
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.