[Monitor] Adding new multi-dimensional metrics API by gucalder · Pull Request #1620 · Azure/azure-rest-api-specs

gucalder · 2017-08-31T16:38:56Z

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes.
Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

I have read the contribution guidelines.
My spec meets the review criteria:
- The spec conforms to the Swagger 2.0 specification.
- The spec follows the guidelines described in the Swagger checklist document.
- Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…ng issue Azure#1475: incorrect example in LogProfiles API documentation for CreateOrUpdate, fixing incorrect logProfiles example names.

…PI call

… into current

…e file.

… into current

…ivityLogAlerts API.

gucalder · 2017-08-31T16:41:59Z

First part of the, now closed, PR #1614. This part includes only changes to data-plane.

salameer · 2017-08-31T17:43:52Z

@jianghaolu this is Data plane btw, so ARM guidelines and RPC linter rules are not enforced here. The focus should be more on SDK and good practices that you would recommend

azuresdkciprbot · 2017-08-31T17:43:54Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/data-plane/readme.md
Before the PR: Warning(s): 1 Error(s): 3
After the PR: Warning(s): 1 Error(s): 3

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

jianghaolu · 2017-08-31T19:06:02Z

@salameer @sergey-shandar was kind enough to take over - but I agree with what you said :)

sergey-shandar · 2017-09-01T05:33:09Z

@gucalder I'll publish my review tomorrow.

… into currentAltMetrics

azuresdkciprbot · 2017-09-01T17:17:44Z

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/monitor/data-plane/readme.md
Before the PR: Warning(s): 1 Error(s): 3
After the PR: Warning(s): 1 Error(s): 3

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

sergey-shandar

LGTM

AutorestCI · 2017-09-01T18:43:16Z

Azure/azure-sdk-for-python#1409

AutorestCI · 2017-09-01T18:43:23Z

No modification for AutorestCI/azure-sdk-for-ruby

AutorestCI · 2017-09-01T18:44:36Z

No modification for AutorestCI/azure-sdk-for-node

gucalder added 13 commits July 27, 2017 13:01

Catching up with missing commits (not moved to the new branch), fFixi…

dae5cba

…ng issue Azure#1475: incorrect example in LogProfiles API documentation for CreateOrUpdate, fixing incorrect logProfiles example names.

Removing success response code from example for log profiles delete A…

8a339ef

…PI call

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

764f130

… into current

Fixing some warnings and one example

d04983f

Fixing issues with the examples validation.

ca4db34

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

d596398

… into current

Fixing one example.

b1bda80

Adding tags and location in the proper place for two examples.

6c48a91

Fixing name change in the body parameter and the corresponding exampl…

3449ce9

…e file.

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

c266d97

… into current

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

5ed235c

… into current

Adding new Multi-Dim Metrics API. Fixing typo in documentation of Act…

2a1d6b2

…ivityLogAlerts API.

Undoing type fix in resource-manager to properly sequence the PRs

9eee7e2

msftclas added the cla-not-required label Aug 31, 2017

azuresdkci assigned jianghaolu Aug 31, 2017

gucalder mentioned this pull request Aug 31, 2017

[Monitor] Adding proper error response behavior to the Action Groups API. Fixing documentation typos in the Activity Log Alerts and Action Groups APIs. #1622

Merged

10 tasks

sergey-shandar assigned sergey-shandar and unassigned jianghaolu Aug 31, 2017

gucalder mentioned this pull request Aug 31, 2017

[Monitor] Adding multi-dim metrics API, improving error response for Action Groups API, and fixing some documentation typos (from Swagger) Azure/azure-sdk-for-net#3646

Merged

8 tasks

sergey-shandar added the DataPlane label Sep 1, 2017

Merge branch 'current' of https://github.com/Azure/azure-rest-api-specs…

bbeb482

… into currentAltMetrics

sergey-shandar approved these changes Sep 1, 2017

View reviewed changes

sergey-shandar merged commit 98e0e15 into Azure:current Sep 1, 2017

AutorestCI mentioned this pull request Sep 1, 2017

[Monitor] Adding new multi-dimensional metrics API Azure/azure-sdk-for-python#1409

Closed

gucalder deleted the currentAltMetrics branch September 12, 2017 23:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Monitor] Adding new multi-dimensional metrics API#1620

[Monitor] Adding new multi-dimensional metrics API#1620
sergey-shandar merged 14 commits intoAzure:currentfrom
AuxMon:currentAltMetrics

gucalder commented Aug 31, 2017 •

edited by azuresdkci

Loading

Uh oh!

gucalder commented Aug 31, 2017

Uh oh!

salameer commented Aug 31, 2017

Uh oh!

azuresdkciprbot commented Aug 31, 2017

Uh oh!

jianghaolu commented Aug 31, 2017

Uh oh!

sergey-shandar commented Sep 1, 2017

Uh oh!

azuresdkciprbot commented Sep 1, 2017

Uh oh!

sergey-shandar left a comment

Uh oh!

AutorestCI commented Sep 1, 2017

Uh oh!

AutorestCI commented Sep 1, 2017

Uh oh!

AutorestCI commented Sep 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

gucalder commented Aug 31, 2017 • edited by azuresdkci Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR information

Quality of Swagger

Uh oh!

gucalder commented Aug 31, 2017

Uh oh!

salameer commented Aug 31, 2017

Uh oh!

azuresdkciprbot commented Aug 31, 2017

Uh oh!

jianghaolu commented Aug 31, 2017

Uh oh!

sergey-shandar commented Sep 1, 2017

Uh oh!

azuresdkciprbot commented Sep 1, 2017

Uh oh!

sergey-shandar left a comment

Choose a reason for hiding this comment

Uh oh!

AutorestCI commented Sep 1, 2017

Uh oh!

AutorestCI commented Sep 1, 2017

Uh oh!

AutorestCI commented Sep 1, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gucalder commented Aug 31, 2017 •

edited by azuresdkci

Loading