[Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2019-12-01-preview by solankisamir · Pull Request #8066 · Azure/azure-rest-api-specs

solankisamir · 2020-01-03T19:45:11Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

azure-pipelines · 2020-01-03T19:45:30Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-03T19:46:17Z

Azure Pipelines successfully started running 1 pipeline(s).

solankisamir · 2020-01-03T19:47:10Z

This is PR related to #8046. We couldn't the apim-2019-12-01-preview branch as it was read-only. Hence created a clone here and working on edits here.

openapi-sdkautomation · 2020-01-03T19:48:15Z

azure-sdk-for-net - Release

❌ failed [Logs] [Expand Details]

❌ Generate from 13fb704 with merge commit ec0ae41. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

❌Microsoft.Azure.Management.ApiManagement [Logs] [Release SDK Changes]

Failed to create the package Microsoft.Azure.Management.ApiManagement.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {}

openapi-sdkautomation · 2020-01-03T19:48:16Z

azure-sdk-for-go - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 13fb704 with merge commit ec0ae41. SDK Automation 13.0.17.20191226.1
️✔️apimanagement/mgmt/2016-07-07 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2016-07-07.zip
️✔️apimanagement/mgmt/2016-10-10 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2016-10-10.zip
️✔️apimanagement/mgmt/2017-03-01 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2017-03-01.zip
️✔️apimanagement/mgmt/2018-01-01 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2018-01-01.zip
️✔️apimanagement/mgmt/2019-01-01 [Logs] [Release SDK Changes]
- apimanagement.mgmt.2019-01-01.zip
️✔️preview/apimanagement/mgmt/2018-06-01-preview [Logs] [Release SDK Changes]
- preview.apimanagement.mgmt.2018-06-01-preview.zip

openapi-sdkautomation · 2020-01-03T19:48:19Z

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 13fb704 with merge commit ec0ae41. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-apimanagement [Logs] [Release SDK Changes]

azure-arm-apimanagement-5.1.1.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
[npmPack] created ./dist/arm-apimanagement.js in 1.7s

openapi-sdkautomation · 2020-01-03T19:48:20Z

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2020-01-03T19:48:22Z

azure-sdk-for-python - Release

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 13fb704 with merge commit ec0ae41. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-apimanagement [Logs] [Release SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

azure-pipelines · 2020-01-03T19:58:45Z

Azure Pipelines successfully started running 1 pipeline(s).

solankisamir · 2020-01-05T19:22:29Z

@NullMDR I am trying to fix the prettier issues using https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/ci-fix.md, but I am getting this error

D:\github\azure-rest-api-specs>npm install prettier-fix
npm ERR! code E404
npm ERR! 404 Not Found - GET https://registry.npmjs.org/prettier-fix - Not found
npm ERR! 404
npm ERR! 404 'prettier-fix@latest' is not in the npm registry.
npm ERR! 404 You should bug the author to publish it (or use the name yourself!)
npm ERR! 404
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\sasolank\AppData\Roaming\npm-cache_logs\2020-01-05T19_20_03_381Z-debug.log

PhoenixHe-NV · 2020-01-06T03:24:44Z

@solankisamir You need

npm install; npm run prettier -- --write "specification/apimanagement/**/*.json"

solankisamir · 2020-01-06T16:51:08Z

@NullMDR ran the command and hit the issue below. I don't have the azure-rest-api-specs-test repos locally. Do I need to get that?
debug_log

PS D:\github\azure-rest-api-specs> npm install; npm run prettier -- --write "specification/apimanagement/**/*.json"

azure-rest-api-specs-tests@0.1.0 postinstall D:\github\azure-rest-api-specs
scripts/switch-to-preproduction.sh
npm ERR! errno 1
npm ERR! azure-rest-api-specs-tests@0.1.0 postinstall: scripts/switch-to-preproduction.sh
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the azure-rest-api-specs-tests@0.1.0 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\sasolank\AppData\Roaming\npm-cache_logs\2020-01-06T16_40_16_473Z-debug.log
npm ERR! missing script: prettier

npm ERR! A complete log of this run can be found in:
npm ERR! C:\Users\sasolank\AppData\Roaming\npm-cache_logs\2020-01-06T16_40_18_669Z-debug.log

ryansbenson

One minor change

ryansbenson · 2020-01-06T23:55:51Z

...agement/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/definitions.json

You shouldn't have an id field in the properties section of a resource. It conflicts with the top level id property. Please find a different name.

It's on the top level, not inside "properties".

@ryansbenson please see @vfedonkin comment. This is a contract associated with a proxy resource and we are just adding id to fix the ARM warnings generated as part of live traffic.

@ryansbenson, @solankisamir , I think we will need to modify all entities to have our fields inside "properties", but it should be done in our next version, since we already behind the schedule for the version we trying to release.

@ryansbenson a gentle ping on this!

@ryansbenson we fixed this in the spec to unblock it. Can you review again?

PhoenixHe-NV · 2020-01-07T03:25:20Z

@solankisamir Please merge from latest master to pick up latest scripts and try again

…19-01-01 to version 2019-12-01-preview

* ApiManagement - renaming /properties entity to /namedValues * ApiManagement - renaming parameter name: propId to namedValueId

* ApiManagement - async operatins for NamedValues and ApiSchemas * ApiManagement - client secrets in IdentityProvider * ApiManagement - json format fixes * ApiManagement - examples fixes * ApiManagement - fixed identtyProviderContract * ApiManagement - secrets in subscriptions * ApiManagement - secrets in OpenIdConnectProviders and AuthServers * ApiManagement - secrets in TenantAccess * ApiManagement - fix example * ApiManagement - fixes

* ApiManagement - tagDescription id * ApiManagement - policyDescriptions * ApiManagement - policyDescriptions small fix * ApiManagement - policyDescriptions sample * ApiManagement - revisions id and api schema doc * ApiManagement - tag descriptions list example * ApiManagement - ciphers info

azure-pipelines · 2020-01-15T02:36:38Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-15T02:38:08Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2020-01-16T06:13:13Z

Azure Pipelines successfully started running 1 pipeline(s).

mmyyrroonn · 2020-01-16T06:14:41Z

/azp run automation - sdk

azure-pipelines · 2020-01-16T06:14:52Z

Azure Pipelines successfully started running 1 pipeline(s).

mmyyrroonn · 2020-01-16T07:15:21Z

@ryansbenson sorry! I made a mistake to merge it. Could you please review this PR, if still need some change we can open another or revert this one. @solankisamir Sorry. Please hold on the following process since ARM didn't sign off yet. Thanks.

PhoenixHe-NV · 2020-01-16T08:03:52Z

@myronfanqiu You can create a PR to revert this one

… add version preview/2019-12-01-preview (#8066)" This reverts commit ec0ae41.

sanjaiganesh · 2020-01-17T21:23:51Z

For all async operations, add x-ms-long-running-operation:true and

, add "x-ms-long-running-operation-options" extension with "final-state-via" property.

"x-ms-long-running-operation-options": {
  "final-state-via": "location"
}

or

"x-ms-long-running-operation-options": {
  "final-state-via": "azure-async-operation"
}

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimapis.json:2361 in 13fb704. [](commit_id = 13fb704, deletion_comment = False)

sanjaiganesh · 2020-01-17T21:26:14Z

...ent/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimnamedvalues.json

+        "responses": {
+          "202": {
+            "description": "Request to update NamedValue was accepted.",
+            "headers": {


For all async operations, add x-ms-long-running-operation:true and

, add "x-ms-long-running-operation-options" extension with "final-state-via" property.

"x-ms-long-running-operation-options": { "final-state-via": "location" }

or

"x-ms-long-running-operation-options": { "final-state-via": "azure-async-operation" }

sanjaiganesh · 2020-01-17T21:26:52Z

...ent/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimnamedvalues.json

+  "paths": {
+    "/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/Microsoft.ApiManagement/service/{serviceName}/namedValues": {
+      "get": {
+        "tags": [


missing ListBySubscrition and ListByResourceGroup calls

We don't have such methods, "ListByService" only

sanjaiganesh · 2020-01-17T21:28:59Z

...ent/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimnamedvalues.json

+          }
+        ],
+        "responses": {
+          "202": {


add sync response 200 as well.. as service could respond synchronously if no changes.

We use 204 for "update was successful" since no any data returned

sanjaiganesh · 2020-01-17T21:29:56Z

...ent/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimnamedvalues.json

+              "Location": {
+                "description": "The URL where the status of the long running operation can be checked.",
+                "type": "string"
+              }


check other comments on LRO tracking extension annotation

@sanjaiganesh , should we remove this header description and use this instead?:

"x-ms-long-running-operation-options": {
"final-state-via": "location"
}

sanjaiganesh · 2020-01-17T21:32:43Z

looks fine.. added few comments. please address them in separate PR. added armsignoff.

solankisamir · 2020-01-17T23:22:24Z

looks fine.. added few comments. please address them in separate PR. added armsignoff.

@sanjaiganesh Thanks for the review. @vfedonkin can you create another PR with the changes requested.

openapi-assignment-bot bot assigned mmyyrroonn Jan 3, 2020

solankisamir mentioned this pull request Jan 3, 2020

[Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2019-12-01-preview #8046

Closed

2 tasks

openapi-sdkautomation bot mentioned this pull request Jan 3, 2020

[AutoPR Microsoft.Azure.Management.ApiManagement] [Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2019-12-01-preview AzureSDKAutomation/azure-sdk-for-net#278

Closed

solankisamir added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required API Management labels Jan 5, 2020

solankisamir requested review from promoisha and vfedonkin January 6, 2020 19:34

ryansbenson reviewed Jan 7, 2020

View reviewed changes

ryansbenson added the ARMChangesRequested label Jan 7, 2020

solankisamir and others added 6 commits January 7, 2020 15:53

Adds base for updating Microsoft.ApiManagement from version stable/20…

6eb8650

…19-01-01 to version 2019-12-01-preview

Updates readme

0584673

Updates API version in new specs and examples

e687a66

ApiManagement - renaming /properties entity to /namedValues (Azure#7683)

6485cf9

* ApiManagement - renaming /properties entity to /namedValues * ApiManagement - renaming parameter name: propId to namedValueId

solankisamir added 2 commits January 14, 2020 18:32

removed id definition

5b5359c

fixed example for tooling.

e285f4b

removed space

13fb704

vfedonkin approved these changes Jan 16, 2020

View reviewed changes

mmyyrroonn closed this Jan 16, 2020

mmyyrroonn reopened this Jan 16, 2020

mmyyrroonn merged commit ec0ae41 into Azure:master Jan 16, 2020

openapi-sdkautomation bot mentioned this pull request Jan 16, 2020

[AutoPR Microsoft.Azure.Management.ApiManagement] [Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2019-12-01-preview AzureSDKAutomation/azure-sdk-for-net#330

Open

arifsundrani mentioned this pull request Jan 16, 2020

Make ApiSchema GET Contract consistent for all api Types #6372

Closed

mmyyrroonn added a commit that referenced this pull request Jan 17, 2020

Revert "[Hub Generated] Review request for Microsoft.ApiManagement to…

3777ce6

… add version preview/2019-12-01-preview (#8066)" This reverts commit ec0ae41.

mmyyrroonn mentioned this pull request Jan 17, 2020

Revert "[Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2019-12-01-preview" #8176

Closed

sanjaiganesh reviewed Jan 17, 2020

View reviewed changes

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Jan 17, 2020

vfedonkin mentioned this pull request Jan 24, 2020

ApiManagement - long running operations #8225

Merged

5 tasks

Comments

Conversation

solankisamir commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

azure-pipelines bot commented Jan 3, 2020

Uh oh!

azure-pipelines bot commented Jan 3, 2020

Uh oh!

solankisamir commented Jan 3, 2020

Uh oh!

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net - Release

Uh oh!

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go - Release

Uh oh!

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js - Release

Uh oh!

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java - Release

Uh oh!

openapi-sdkautomation bot commented Jan 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python - Release

Uh oh!

azure-pipelines bot commented Jan 3, 2020

Uh oh!

solankisamir commented Jan 5, 2020

Uh oh!

PhoenixHe-NV commented Jan 6, 2020

Uh oh!

solankisamir commented Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ryansbenson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PhoenixHe-NV commented Jan 7, 2020

Uh oh!

azure-pipelines bot commented Jan 15, 2020

Uh oh!

azure-pipelines bot commented Jan 15, 2020

Uh oh!

azure-pipelines bot commented Jan 16, 2020

Uh oh!

mmyyrroonn commented Jan 16, 2020

Uh oh!

azure-pipelines bot commented Jan 16, 2020

Uh oh!

mmyyrroonn commented Jan 16, 2020

Uh oh!

PhoenixHe-NV commented Jan 16, 2020

Uh oh!

sanjaiganesh commented Jan 17, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

openapi-sdkautomation bot commented Jan 3, 2020 •

edited

Loading

solankisamir commented Jan 6, 2020 •

edited

Loading

solankisamir Jan 15, 2020 •

edited

Loading