[Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2019-12-01-preview by solankisamir · Pull Request #8046 · Azure/azure-rest-api-specs

solankisamir · 2019-12-30T23:45:48Z

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.

…19-01-01 to version 2019-12-01-preview

* ApiManagement - renaming /properties entity to /namedValues * ApiManagement - renaming parameter name: propId to namedValueId

* ApiManagement - async operatins for NamedValues and ApiSchemas * ApiManagement - client secrets in IdentityProvider * ApiManagement - json format fixes * ApiManagement - examples fixes * ApiManagement - fixed identtyProviderContract * ApiManagement - secrets in subscriptions * ApiManagement - secrets in OpenIdConnectProviders and AuthServers * ApiManagement - secrets in TenantAccess * ApiManagement - fix example * ApiManagement - fixes

* ApiManagement - tagDescription id * ApiManagement - policyDescriptions * ApiManagement - policyDescriptions small fix * ApiManagement - policyDescriptions sample * ApiManagement - revisions id and api schema doc * ApiManagement - tag descriptions list example * ApiManagement - ciphers info

* update error response for apim deployment * disable gateway * user assigned identities * api version contraint * update examples * fix model issues in examples * update example * replace sasolankrp with apimService1 Co-authored-by: Samir Solanki <samirsolanki@outlook.com>

azure-pipelines · 2019-12-30T23:46:07Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2019-12-30T23:46:40Z

Azure Pipelines successfully started running 1 pipeline(s).

openapi-sdkautomation · 2019-12-30T23:48:34Z

azure-sdk-for-java

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

openapi-sdkautomation · 2019-12-30T23:48:34Z

azure-sdk-for-python

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 0615132 with merge commit a34460827bfc0800ed623de420fc779d1a6c3683. SDK Automation 13.0.17.20191226.1

️✔️azure-mgmt-apimanagement [Logs] [Preview SDK Changes]

[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'
[build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
[build_package]   warnings.warn(msg)
[build_package] warning: no files found matching '*.py' under directory 'tests'
[build_package] warning: no files found matching '*.yaml' under directory 'tests'

openapi-sdkautomation · 2019-12-30T23:48:37Z

azure-sdk-for-net

❌ failed [Logs] [Expand Details]

❌ Generate from 0615132 with merge commit a34460827bfc0800ed623de420fc779d1a6c3683. SDK Automation 13.0.17.20191226.1

[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied
[AutoRest] realpath(): Permission denied

❌Microsoft.Azure.Management.ApiManagement [Logs] [Preview SDK Changes]

Failed to create the package Microsoft.Azure.Management.ApiManagement.
Error: dotnet msbuild build.proj /t:CreateNugetPackage /p:Scope=apimanagement /v:n /p:SkipTests=true , {}

openapi-sdkautomation · 2019-12-30T23:48:42Z

azure-sdk-for-js

️✔️ succeeded [Logs] [Expand Details]

️✔️ Generate from 0615132 with merge commit a34460827bfc0800ed623de420fc779d1a6c3683. SDK Automation 13.0.17.20191226.1

️✔️@azure/arm-apimanagement [Logs] [Preview SDK Changes]

azure-arm-apimanagement-5.1.1.tgz

[npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
[npmPack] loaded rollup.config.js with warnings
[npmPack] (!) Unused external imports
[npmPack] default imported from external module 'rollup' but never used
[npmPack] 
[npmPack] ./esm/apiManagementClient.js → ./dist/arm-apimanagement.js...
[npmPack] created ./dist/arm-apimanagement.js in 1.7s

openapi-sdkautomation · 2019-12-30T23:48:46Z

azure-sdk-for-go

⚠️ warning [Logs] [Expand Details]

⚠️ Generate from 0615132 with merge commit a34460827bfc0800ed623de420fc779d1a6c3683. SDK Automation 13.0.17.20191226.1
⚠️apimanagement/mgmt/2016-07-07 [Logs]
```
No file is changed.
```
⚠️apimanagement/mgmt/2016-10-10 [Logs]
```
No file is changed.
```
⚠️apimanagement/mgmt/2017-03-01 [Logs]
```
No file is changed.
```
⚠️apimanagement/mgmt/2018-01-01 [Logs]
```
No file is changed.
```
⚠️apimanagement/mgmt/2019-01-01 [Logs]
```
No file is changed.
```
⚠️preview/apimanagement/mgmt/2018-06-01-preview [Logs]
```
No file is changed.
```

azuresdkci · 2019-12-31T00:04:16Z

Can one of the admins verify this patch?

azure-pipelines · 2019-12-31T00:59:15Z

Azure Pipelines successfully started running 1 pipeline(s).

solankisamir · 2020-01-02T20:41:54Z

@NullMDR .net sdk might require some breaking changes in the SchemaContract definition, as we had put in custom implementation there. So the failure is expected.

PhoenixHe-NV · 2020-01-03T04:31:01Z

@isra-fel Another .net generation failure FYI. From log I guess it's related to the dotnet project settings.

@solankisamir Everything else looks good to me. You can fix the prettier check by following https://aka.ms/AA6h31t

isra-fel · 2020-01-03T05:24:41Z

Got it. I'm fine with .net SDK

solankisamir · 2020-01-03T19:48:27Z

@NullMDR @isra-fel created a clone of this PR #8066, as I couldn't edit changes in this branch.

solankisamir and others added 7 commits October 17, 2019 08:41

Adds base for updating Microsoft.ApiManagement from version stable/20…

e0ad99c

…19-01-01 to version 2019-12-01-preview

Updates readme

a622b0f

Updates API version in new specs and examples

f909839

ApiManagement - renaming /properties entity to /namedValues (#7683)

9d79855

* ApiManagement - renaming /properties entity to /namedValues * ApiManagement - renaming parameter name: propId to namedValueId

solankisamir requested review from promoisha and vfedonkin December 30, 2019 23:47

solankisamir added the API Management label Dec 30, 2019

azuresdkci assigned PhoenixHe-NV Dec 31, 2019

azuresdkci requested a review from PhoenixHe-NV December 31, 2019 00:08

PhoenixHe-NV closed this Dec 31, 2019

PhoenixHe-NV reopened this Dec 31, 2019

openapi-sdkautomation bot mentioned this pull request Dec 31, 2019

[AutoPR Microsoft.Azure.Management.ApiManagement] [Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2019-12-01-preview AzureSDKAutomation/azure-sdk-for-net#266

Open

solankisamir added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 2, 2020

solankisamir mentioned this pull request Jan 3, 2020

[Hub Generated] Review request for Microsoft.ApiManagement to add version preview/2019-12-01-preview #8066

Merged

2 tasks

solankisamir closed this Jan 3, 2020

Comments

Conversation

solankisamir commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution checklist:

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

azure-pipelines bot commented Dec 30, 2019

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-java

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-python

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-net

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-js

Uh oh!

openapi-sdkautomation bot commented Dec 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

azure-sdk-for-go

Uh oh!

azuresdkci commented Dec 31, 2019

Uh oh!

azure-pipelines bot commented Dec 31, 2019

Uh oh!

solankisamir commented Jan 2, 2020

Uh oh!

PhoenixHe-NV commented Jan 3, 2020

Uh oh!

isra-fel commented Jan 3, 2020

Uh oh!

solankisamir commented Jan 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

solankisamir commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading

openapi-sdkautomation bot commented Dec 30, 2019 •

edited

Loading