Skip to content

Comments

Apim 2019 12 01 preview#7725

Merged
solankisamir merged 7 commits intoAzure:apim-2019-12-01-previewfrom
vfedonkin:apim-2019-12-01-preview
Dec 18, 2019
Merged

Apim 2019 12 01 preview#7725
solankisamir merged 7 commits intoAzure:apim-2019-12-01-previewfrom
vfedonkin:apim-2019-12-01-preview

Conversation

@vfedonkin
Copy link
Contributor

@vfedonkin vfedonkin commented Nov 7, 2019

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 7, 2019

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8841

@AutorestCI
Copy link

AutorestCI commented Nov 7, 2019

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

Copy link
Member

@solankisamir solankisamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look at the failing validations in the pipeline?

@vfedonkin
Copy link
Contributor Author

failing validations - looks like new version of autorest tool failing (have the same on my dev machine) - previous commit 96132bc wich was successful but now is broken with the same errors when I run validation against it.

@vfedonkin
Copy link
Contributor Author

After upgrading autorest to latest version, validation is fine on my local dev machine.

@vfedonkin vfedonkin force-pushed the apim-2019-12-01-preview branch from c16fbbe to 96132bc Compare November 25, 2019 23:12
@vfedonkin
Copy link
Contributor Author

Reverted changes to commit 96132bc to check if validation will be ok for this commit (was ok last time)

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@solankisamir solankisamir self-requested a review December 17, 2019 18:16
@solankisamir solankisamir merged commit 53e8145 into Azure:apim-2019-12-01-preview Dec 18, 2019
solankisamir pushed a commit to solankisamir/azure-rest-api-specs that referenced this pull request Jan 8, 2020
* ApiManagement - tagDescription id

* ApiManagement - policyDescriptions

* ApiManagement - policyDescriptions small fix

* ApiManagement - policyDescriptions sample

* ApiManagement - revisions id and api schema doc

* ApiManagement - tag descriptions list example

* ApiManagement - ciphers info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants