Skip to content

Comments

Apim 2019 12 01 preview#7705

Merged
solankisamir merged 10 commits intoAzure:apim-2019-12-01-previewfrom
vfedonkin:apim-2019-12-01-preview
Nov 5, 2019
Merged

Apim 2019 12 01 preview#7705
solankisamir merged 10 commits intoAzure:apim-2019-12-01-previewfrom
vfedonkin:apim-2019-12-01-preview

Conversation

@vfedonkin
Copy link
Contributor

@vfedonkin vfedonkin commented Nov 5, 2019 •
edited
Loading

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

@AutorestCI
Copy link

AutorestCI commented Nov 5, 2019 •
edited
Loading

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#8412

@azuresdkci
Copy link
Contributor

azuresdkci commented Nov 5, 2019

Can one of the admins verify this patch?

@AutorestCI
Copy link

AutorestCI commented Nov 5, 2019 •
edited
Loading

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

@solankisamir
Copy link
Member

solankisamir commented Nov 5, 2019 •
edited
Loading

can you fix the model validation errors? #Resolved

solankisamir
solankisamir requested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@solankisamir solankisamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model validation errors need to be fixed

@AutorestCI AutorestCI mentioned this pull request Nov 5, 2019
Merged
solankisamir
solankisamir reviewed Nov 5, 2019
View reviewed changes
...icrosoft.ApiManagement/preview/2019-12-01-preview/examples/ApiManagementGetTenantAccess.json
@@ -10,8 +10,6 @@
"200": {
"body": {
"id": "5600b59375ff190048030003",
Copy link
Member

@solankisamir solankisamir Nov 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strange ARM does not complain on this? No properties bag

@solankisamir
Copy link
Member

solankisamir commented Nov 5, 2019 

        "$ref": "./examples/ApiManagementUpdateTenantAccess.json"

This example Needs to be updated.
https://dev.azure.com/azure-sdk/public/_build/results?buildId=180297&view=logs&j=8d2f9c49-cd83-5a9d-f3fe-2fd651afa742&t=43324f1f-6724-5d61-785f-f0ac9fd256a1&l=71

Refers to: specification/apimanagement/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimtenant.json:141 in 6dd5fbc. [](commit_id = 6dd5fbc, deletion_comment = False)

solankisamir
solankisamir requested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@solankisamir solankisamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few fixes and we should be good to merge. Thanks

@solankisamir solankisamir merged commit a1d23e2 into Azure:apim-2019-12-01-preview Nov 5, 2019
solankisamir pushed a commit to solankisamir/azure-rest-api-specs that referenced this pull request Jan 8, 2020
@vfedonkin @solankisamir
Apim 2019 12 01 preview (Azure#7705)
a8dee34 
* ApiManagement - async operatins for NamedValues and ApiSchemas

* ApiManagement - client secrets in IdentityProvider

* ApiManagement - json format fixes

* ApiManagement - examples fixes

* ApiManagement - fixed identtyProviderContract

* ApiManagement - secrets in subscriptions

* ApiManagement - secrets in OpenIdConnectProviders and AuthServers

* ApiManagement - secrets in TenantAccess

* ApiManagement - fix example

* ApiManagement - fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solankisamir solankisamir solankisamir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vfedonkin @AutorestCI @azuresdkci @solankisamir