ApiManagement - renaming /properties entity to /namedValues by vfedonkin · Pull Request #7683 · Azure/azure-rest-api-specs

vfedonkin · 2019-10-31T21:06:16Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

AutorestCI · 2019-10-31T21:07:16Z

Automation for azure-sdk-for-python

Encountered a Subprocess error: (azure-sdk-for-python)

Command: ['/usr/local/bin/autorest', '/tmp/tmpf286v4d2/rest/specification/apimanagement/resource-manager/readme.md', '--perform-load=false', '--swagger-to-sdk', '--output-artifact=configuration.json', '--input-file=foo', '--output-folder=/tmp/tmpg__60t8h']
Finished with return code 7
and output:

AutoRest code generation utility [version: 2.0.4283; node: v8.12.0]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
Failure:
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
Error: Unable to start AutoRest Core from /root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core
    at main (/opt/node_modules/autorest/dist/app.js:232:19)
    at <anonymous>

/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33
    autorest_core_1.Shutdown();
    ^
ReferenceError: autorest_core_1 is not defined
    at process.on (/root/.autorest/@microsoft.azure_autorest-core@2.0.4405/node_modules/@microsoft.azure/autorest-core/dist/app.js:33:5)
    at emitOne (events.js:121:20)
    at process.emit (events.js:211:7)
    at process.emit (/node_modules/source-map-support/source-map-support.js:439:21)
fs.js:612
  return binding.close(fd);
                 ^

Error: EBADF: bad file descriptor, close
    at Object.fs.closeSync (fs.js:612:18)
    at StaticVolumeFile.shutdown (/opt/node_modules/autorest/dist/static-loader.js:352:10)
    at StaticFilesystem.shutdown (/opt/node_modules/autorest/dist/static-loader.js:406:17)
    at process.exit.n [as exit] (/opt/node_modules/autorest/dist/static-loader.js:169:11)
    at printErrorAndExit (/node_modules/source-map-support/source-map-support.js:423:11)
    at process.emit (/node_modules/source-map-support/source-map-support.js:435:16)
    at process._fatalException (bootstrap_node.js:391:26)

AutorestCI · 2019-10-31T21:12:51Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

azuresdkci · 2019-10-31T23:01:55Z

Can one of the admins verify this patch?

solankisamir · 2019-10-31T23:43:23Z

...ement/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimanagement.json

    },
-    "PropertyIdParameter": {
+    "NamedValueIdParameter": {
      "name": "propId",


propId [](start = 15, length = 6)

rename to nameValueId #Closed

once you do that.. you will need to change the examples also.

In reply to: 341407943 [](ancestors = 341407943)

Done #Closed

solankisamir · 2019-10-31T23:44:18Z

...ent/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimnamedvalues.json

  "info": {
    "title": "ApiManagementClient",
-    "description": "Use these REST APIs for performing operations on Property entity associated with your Azure API Management deployment. API Management policies are a powerful capability of the system that allow the publisher to change the behavior of the API through configuration. Policies are a collection of statements that are executed sequentially on the request or response of an API. Policy statements can be constructed using literal text values, policy expressions, and properties. Each API Management service instance has a properties collection of key/value pairs that are global to the service instance. These properties can be used to manage constant string values across all API configuration and policies.",
+    "description": "Use these REST APIs for performing operations on NamedValue entity associated with your Azure API Management deployment. API Management policies are a powerful capability of the system that allow the publisher to change the behavior of the API through configuration. Policies are a collection of statements that are executed sequentially on the request or response of an API. Policy statements can be constructed using literal text values, policy expressions, and NamedValues. Each API Management service instance has a NamedValues collection of key/value pairs that are global to the service instance. These NamedValues can be used to manage constant string values across all API configuration and policies.",


Usually we use upper case. Like "Lists a collection of all external Caches in the specified service instance."

solankisamir · 2019-10-31T23:45:19Z

...ent/resource-manager/Microsoft.ApiManagement/preview/2019-12-01-preview/apimnamedvalues.json

+        "operationId": "NamedValue_ListByService",
+        "description": "Lists a collection of NamedValues defined within a service instance.",
        "externalDocs": {
          "url": "https://docs.microsoft.com/en-us/azure/api-management/api-management-howto-properties"


properties [](start = 93, length = 10)

we should ask the PM to rename the doc name :) #Closed

I asked Mike to do this #Closed

solankisamir

left some feedback. rest looks good.

solankisamir

* ApiManagement - renaming /properties entity to /namedValues * ApiManagement - renaming parameter name: propId to namedValueId

ApiManagement - renaming /properties entity to /namedValues

77bd403

vfedonkin requested a review from solankisamir as a code owner October 31, 2019 21:06

AutorestCI mentioned this pull request Oct 31, 2019

[AutoPR apimanagement/resource-manager] ApiManagement - renaming /properties entity to /namedValues Azure/azure-sdk-for-go#6211

Closed

solankisamir reviewed Oct 31, 2019

View reviewed changes

solankisamir requested changes Oct 31, 2019

View reviewed changes

ApiManagement - renaming parameter name: propId to namedValueId

42c82a6

solankisamir approved these changes Nov 1, 2019

View reviewed changes

solankisamir merged commit 9d79855 into Azure:apim-2019-12-01-preview Nov 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ApiManagement - renaming /properties entity to /namedValues#7683

ApiManagement - renaming /properties entity to /namedValues#7683
solankisamir merged 2 commits intoAzure:apim-2019-12-01-previewfrom
vfedonkin:apim-2019-12-01-preview

vfedonkin commented Oct 31, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Oct 31, 2019 •

edited

Loading

Uh oh!

AutorestCI commented Oct 31, 2019 •

edited

Loading

Uh oh!

azuresdkci commented Oct 31, 2019

Uh oh!

solankisamir Oct 31, 2019 •

edited

Loading

Uh oh!

solankisamir Oct 31, 2019

Uh oh!

vfedonkin Nov 1, 2019 •

edited by solankisamir

Loading

Uh oh!

solankisamir Oct 31, 2019

Uh oh!

vfedonkin Nov 1, 2019

Uh oh!

solankisamir Oct 31, 2019 •

edited

Loading

Uh oh!

vfedonkin Nov 1, 2019 •

edited by solankisamir

Loading

Uh oh!

solankisamir left a comment

Uh oh!

solankisamir left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

vfedonkin commented Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

azuresdkci commented Oct 31, 2019

Uh oh!

solankisamir Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir Oct 31, 2019

Choose a reason for hiding this comment

Uh oh!

vfedonkin Nov 1, 2019 • edited by solankisamir Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir Oct 31, 2019

Choose a reason for hiding this comment

Uh oh!

vfedonkin Nov 1, 2019

Choose a reason for hiding this comment

Uh oh!

solankisamir Oct 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vfedonkin Nov 1, 2019 • edited by solankisamir Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solankisamir left a comment

Choose a reason for hiding this comment

Uh oh!

solankisamir left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vfedonkin commented Oct 31, 2019 •

edited

Loading

AutorestCI commented Oct 31, 2019 •

edited

Loading

AutorestCI commented Oct 31, 2019 •

edited

Loading

solankisamir Oct 31, 2019 •

edited

Loading

vfedonkin Nov 1, 2019 •

edited by solankisamir

Loading

solankisamir Oct 31, 2019 •

edited

Loading

vfedonkin Nov 1, 2019 •

edited by solankisamir

Loading