Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TCGC] Adopt getAllOperation #3994

Closed
22 of 23 tasks
Tracked by #4299
archerzz opened this issue Dec 1, 2023 · 0 comments
Closed
22 of 23 tasks
Tracked by #4299

[TCGC] Adopt getAllOperation #3994

archerzz opened this issue Dec 1, 2023 · 0 comments
Assignees
@archerzz
Labels
DPG/RLC v2.1 Post Gallium work DPG

Comments

@archerzz
Copy link
Member

archerzz commented Dec 1, 2023 •
edited
Loading

Per https://github.com/Azure/typespec-azure/issues/2745

Tasks
Beta Give feedback
  1. [TCGC] Provide SdkApiVersionParameter as part of SdkParameter typespec-azure#948
    feature lib:tcgc
    iscai-msft
  2. refactor(emitter): remove description property from top level model #4747
    DPG DPG/RLC v2.1
    archerzz
  3. refactor(tcgc): how we can better represent authentication typespec-azure#951
    design:proposed lib:tcgc
  4. [Bug]: Some SdkMethod interfaces are not exported typespec-azure#969
    bug lib:tcgc
    tadelesh
  5. [TCGC][Feature gap] SdkPackage misses information for whether generate convenient/protocol method typespec-azure#980
    feature lib:tcgc
    iscai-msft
  6. feat(tcgc): SdkMethodParameter should have a way to know location typespec-azure#981
    feature lib:tcgc
    iscai-msft
  7. feat(tcgc): SdkModelPropertyTypeBase.clientDefaultValue should be a concrete type typespec-azure#988
    feature lib:tcgc
  8. feat(auth): support custom scheme of http auth microsoft/typespec#3568
    design:needed lib:http triaged:core
  9. [Bug]: SdkEndpointParamter.clientDefaultValue should have value typespec-azure#989
    bug lib:tcgc
    iscai-msft
  10. [Bug]: SdkHttpResponse.contentTypes? can be empty array typespec-azure#992
    bug lib:tcgc
    iscai-msft
  11. feat(tcgc): use @server description for default endpoint client parameter typespec-azure#1007
    feature lib:tcgc
  12. bug(decorator): hard coded server url in @scenarioService cadl-ranch#597
    bug
    archerzz
  13. bug(tcgc): getSdkHttpParameter() doesn't handle default value typespec-azure#1030
    bug lib:tcgc
  14. bug(tcgc): default name of api version parameter should be api-version typespec-azure#1046
    bug lib:tcgc
    archerzz
  15. feat(tcgc): provide origin of SdkClientType typespec-azure#1060
    feature lib:tcgc
    tadelesh
  16. refactor(dpg): remove unnecessary Creatable property #4841
  17. [Bug][TCGC]: inconsistent encode between SdkMethodParameter and HttpOperationParameter typespec-azure#1084
    bug lib:tcgc
    archerzz
  18. [Bug][TCGC]: apiVersions of subclients can be undefined typespec-azure#1089
    bug lib:tcgc
  19. [Bug][TCGC]: @clientName not work on namespace typespec-azure#1091
    bug lib:tcgc
  20. [Bug][TCGC]: SdkMethodBase.details could be meaningless sometimes typespec-azure#1097
    bug
  21. [Bug][TCGC]: empty name when certain models are used as spread body typespec-azure#1150
    bug lib:tcgc
    tadelesh
  22. [Bug][TCGC]: @server description is used as endpoint parameter description typespec-azure#1212
    bug lib:tcgc
    iscai-msft
  23. [Bug][TCGG]: sub-client should not inherit parent's description if its own is not defined typespec-azure#1249
    bug lib:tcgc
    archerzz
@archerzz archerzz self-assigned this Dec 1, 2023
@chunyu3 chunyu3 added DPG DPG/RLC v2.1 Post Gallium work labels Dec 4, 2023
@chunyu3 chunyu3 mentioned this issue Dec 25, 2023
Closed
2 tasks
@archerzz archerzz mentioned this issue Jan 11, 2024
Closed
This was referenced Apr 8, 2024
Closed
Closed
@archerzz archerzz changed the title [TCGC] Early Adoption of getAllOperation [TCGC] Adoption of getAllOperation May 7, 2024
@archerzz archerzz changed the title [TCGC] Adoption of getAllOperation [TCGC] Adopt getAllOperation May 7, 2024
@archerzz archerzz mentioned this issue May 19, 2024
Closed
archerzz added a commit to archerzz/autorest.csharp that referenced this issue Jun 18, 2024
@archerzz
refactor(generator): remove null check on client description
6cd8d6a 
This is a prerequisite change for Azure#3994 The null check for client description is meaningless, because `ClientBuilder` will add a default description anyway: https://github.com/Azure/autorest.csharp/blob/4d55b600ee877e68675297546e70a765fb679039/src/AutoRest.CSharp/Common/Output/Builders/ClientBuilder.cs#L28-L31
Right now in our emitter, we will set `description` to an empty string: https://github.com/Azure/autorest.csharp/blob/4d55b600ee877e68675297546e70a765fb679039/src/TypeSpec.Extension/Emitter.Csharp/src/lib/client-model-builder.ts#L281
But in TCGC, the `description` will be null.

So, let's remove this meaningless check.
@archerzz archerzz mentioned this issue Jun 18, 2024
Merged
6 tasks
archerzz added a commit that referenced this issue Jun 20, 2024
@archerzz
refactor(generator): remove null check on client description (#4828)
c875f2e 
This is a prerequisite change for #3994 The null check for client description is meaningless, because `ClientBuilder` will add a default description anyway: https://github.com/Azure/autorest.csharp/blob/4d55b600ee877e68675297546e70a765fb679039/src/AutoRest.CSharp/Common/Output/Builders/ClientBuilder.cs#L28-L31
Right now in our emitter, we will set `description` to an empty string: https://github.com/Azure/autorest.csharp/blob/4d55b600ee877e68675297546e70a765fb679039/src/TypeSpec.Extension/Emitter.Csharp/src/lib/client-model-builder.ts#L281
But in TCGC, the `description` will be null.

So, let's remove this meaningless check.
archerzz added a commit to archerzz/autorest.csharp that referenced this issue Jun 20, 2024
@archerzz
refactor(dpg): remove unnecessary Creatable property
1c7ae6d 
This is a prerequisite of Azure#3994
`Creatable` is not used in generator. See:
- `TypeSpecInputClientConverter`: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputClientConverter.cs
- `InputClient`: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/InputClient.cs

Let's remove it.
@archerzz archerzz mentioned this issue Jun 20, 2024
Merged
6 tasks
archerzz added a commit to archerzz/autorest.csharp that referenced this issue Jun 27, 2024
@archerzz
refactor(dpg): remove unnecessary Creatable property
0167e73 
This is a prerequisite of Azure#3994
`Creatable` is not used in generator. See:
- `TypeSpecInputClientConverter`: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputClientConverter.cs
- `InputClient`: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/InputClient.cs

Let's remove it.
ArcturusZhang added a commit that referenced this issue Jun 27, 2024
@archerzz @ArcturusZhang
refactor(dpg): remove unnecessary Creatable property (#4841)
21e46d2 
* refactor(dpg): remove unnecessary `Creatable` property

This is a prerequisite of #3994
`Creatable` is not used in generator. See:
- `TypeSpecInputClientConverter`: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/Serialization/TypeSpecInputClientConverter.cs
- `InputClient`: https://github.com/Azure/autorest.csharp/blob/feature/v3/src/AutoRest.CSharp/Common/Input/InputTypes/InputClient.cs

Let's remove it.

* try to revert the problematic change

* try to add it into peer dep

---------

Co-authored-by: Dapeng Zhang <[email protected]>
archerzz pushed a commit to archerzz/typespec that referenced this issue Jul 17, 2024
feat(http-client-csharp): adopt TCGC getAllOperations
efd9ea9 
- update emitter logic to derive operation defintions from TCGC instead of raw compiler result
- update `ExampleMockValueBuilder` to get constant value from `InputLiteralType`
- add implicit conversion operation from `InputLiteralType` to `InputConstant`
- update unit test cases
- minor error message improvment

part of Azure/autorest.csharp#3994
@archerzz archerzz mentioned this issue Jul 17, 2024
Merged
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this issue Jul 31, 2024
@archerzz
feat(http-client-csharp): adopt TCGC getAllOperations (#3867)
72d544c 
- update emitter logic to derive operation definitions from TCGC instead
of raw compiler output
- temporarily work around the mis-use of `InputParameter.DefaultValue`
for constant values
- add conversion from `InputLiteralType.Value` to
`InputParameter.DefaultValue` in converter
- add implicit conversion operation from `InputLiteralType` to
`InputConstant`
- update unit test cases
- minor error message improvement

part of Azure/autorest.csharp#3994

---------

Co-authored-by: Mingzhe Huang (from Dev Box) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archerzz archerzz

Labels
DPG/RLC v2.1 Post Gallium work DPG
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@archerzz @chunyu3