Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SdkEndpointParamter.clientDefaultValue should have value #989

Closed
4 tasks done
Tracked by #3994
archerzz opened this issue Jun 12, 2024 · 1 comment
Closed
4 tasks done
Tracked by #3994

[Bug]: SdkEndpointParamter.clientDefaultValue should have value #989

archerzz opened this issue Jun 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@archerzz
Copy link
Member

Describe the bug

SdkEndpointParameter extends SdkModelPropertyBase which has clientDefaultValue which should have value for SdkEndpointParameter (like http://localhost:3000). Right now, the value is in SdkEndpointParameter.type.serverUrl

Reproduction

Parse a typespec spec, check the SdkEndpointParameter value

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
  • Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@archerzz archerzz added the bug Something isn't working label Jun 12, 2024
@archerzz archerzz added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Jun 12, 2024
@iscai-msft
Copy link
Contributor

this information is not on the SdkEndpointParameter itself, because we have made our design work fro both templated and non-templated endpoints. Instead, this information is in templateArgs, where if ther's a .clientDefaultValue, that information would be in the template arguments. Closing because this is by design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants