feat(http-client-csharp): adopt TCGC getAllOperations #3867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update emitter logic to derive operation defintions from TCGC instead of raw compiler result - update `ExampleMockValueBuilder` to get constant value from `InputLiteralType` - add implicit conversion operation from `InputLiteralType` to `InputConstant` - update unit test cases - minor error message improvment part of Azure/autorest.csharp#3994
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
|
API change check API changes are not detected in this pull request. |
1 similar comment
|
API change check API changes are not detected in this pull request. |
archerzz
force-pushed
the
http-client-csharp/tcgc/getAllOps
branch
from
48f9cef
to
6f1003e
Compare
|
API change check API changes are not detected in this pull request. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
m-nash
reviewed
Jul 22, 2024
...es/http-client-csharp/generator/TestProjects/Local/Unbranded-TypeSpec/Unbranded-TypeSpec.tsp
Outdated
Show resolved
Hide resolved
archerzz
force-pushed
the
http-client-csharp/tcgc/getAllOps
branch
from
aff35e2
to
03c4ddf
Compare
# Conflicts: # packages/http-client-csharp/emitter/src/lib/client-model-builder.ts # packages/http-client-csharp/emitter/src/lib/converter.ts # packages/http-client-csharp/emitter/src/lib/operation.ts # packages/http-client-csharp/generator/TestProjects/Local/Unbranded-TypeSpec/tspCodeModel.json
This reverts commit 66bc26c.
ArcturusZhang
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InputParameter.DefaultValuefor constant valuesInputLiteralType.ValuetoInputParameter.DefaultValuein converterInputLiteralTypetoInputConstantpart of Azure/autorest.csharp#3994