bug(tcgc): getSdkHttpParameter() doesn't handle default value

[archerzz]

Describe the bug

We try to set a endpoint parameter with default value in Azure/cadl-ranch#598

@server(
  "{endpoint}",
  "Test server endpoint",
  {
    endpoint: string = "http://localhost:3000",
  }
)

The parameter can be fetched in TCGC, but default value is not parsed. Check the source codes of getSdkHttpParameter(), and it seems not handle default value:

typespec-azure/packages/typespec-client-generator-core/src/http.ts

Line 294 in 5c10b3e

export function getSdkHttpParameter(

Reproduction

Just try to parse the definition above.

Checklist

• Follow our Code of Conduct
• Check that this issue is about the Azure libraries for typespec. For bug in the typespec language or core libraries file it in the TypeSpec repo
• Check that there isn't already an issue that request the same bug to avoid creating a duplicate.
• The provided reproduction is a minimal reproducible example of the bug.

[tadelesh]

@iscai-msft i remembered that only when the default value is happened in server endpoint that we will use it as client default value, is that right? if so, it seems we missed this in current code.

[iscai-msft]

Yep, it's only for api version and endpoint. This information is in .templateArguments though, so I don't think this is an issue. Closing. If it's still an issue can you reopen @archerzz

[archerzz]

@iscai-msft for parameters in .templateArguments, looks like I could not get the defaut value unless I parse the __raw.defaultValue. Maybe we should set the .clientDefaultValue?

[iscai-msft]

This is a good point, we purposefully don't take defaultValue into account unless for endpoint or api-version related information. I think we should take into account this information since this is endpoint related. I'm going to make a PR and merge it after I make sure people are ok with it. Thanks @archerzz