Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tcgc): SdkModelPropertyTypeBase.clientDefaultValue should be a concrete type #988

Closed
4 tasks done
Tracked by #3994
archerzz opened this issue Jun 12, 2024 · 1 comment
Closed
4 tasks done
Tracked by #3994
Labels
feature New feature or request lib:tcgc Issues for @azure-tools/typespec-client-generator-core library

Comments

@archerzz
Copy link
Member

Clear and concise description of the problem

Right now, SdkModelPropertyTypeBase.clientDefaultValue is of type any:

I think it should be a more concrete type, like SdkConstantType:

export interface SdkConstantType extends SdkTypeBase {

Otherwise, it would be hard for emitters to determine the type of default value.

Checklist

  • Follow our Code of Conduct
  • Check that this issue is about the Azure libraries for typespec. For feature request in the typespec language or core libraries file it in the TypeSpec repo
  • Read the docs.
  • Check that there isn't already an issue that request the same feature to avoid creating a duplicate.
@archerzz archerzz added the lib:tcgc Issues for @azure-tools/typespec-client-generator-core library label Jun 12, 2024
@tadelesh tadelesh added the feature New feature or request label Jun 12, 2024
@archerzz
Copy link
Member Author

close, per discussion, we thought the corresponding type property should be used to parse the value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request lib:tcgc Issues for @azure-tools/typespec-client-generator-core library
Projects
None yet
Development

No branches or pull requests

2 participants