fix(prover): handle cross-chain messages when proving mbps#20354
Merged
spalladino merged 1 commit intomerge-train/spartanfrom Feb 10, 2026
Merged
fix(prover): handle cross-chain messages when proving mbps#20354spalladino merged 1 commit intomerge-train/spartanfrom
spalladino merged 1 commit intomerge-train/spartanfrom
Conversation
spalladino
force-pushed
the
palla/fix-mbps-proposed-anchor
branch
from
04f9d0b to
081f417
Compare
spalladino
force-pushed
the
palla/fix-proving-mbps
branch
from
46c1c0e to
e7fd8e8
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
spalladino
force-pushed
the
palla/fix-proving-mbps
branch
from
e7fd8e8 to
531a026
Compare
We were re-inserting cross chain messages in world state for every block in the checkpoint, where we only need to insert them on the first block. This fixes it, and also extends the epochs-mbps e2e test suite to also assert that the multi-block checkpoints get properly proven.
spalladino
force-pushed
the
palla/fix-proving-mbps
branch
from
531a026 to
91608fe
Compare
PhilWindle
approved these changes
Feb 10, 2026
spalladino
added a commit
that referenced
this pull request
Feb 10, 2026
Similar to how we had a MockGossipSub network we used in tests for nodes to talk to each other, this commit adds a MockReqResp layer to enable reqresp. Also adds an integration_reqresp test in p2p to test it (we should be able to migrate other integration tests in p2p to it as well?). This allows us to re-enable the mbps assertion for proving blocks with txs anchored to uncheckpointed blocks. It was failing because the prover node failed to follow the uncheckpointed chain, so it rejected the txs anchored to those blocks, and then could not fetch them via reqresp since it was not enabled. Proper fix is actually having the prover node follow the uncheckpointed chain. But that will come in a later PR. Builds on #20354
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
BEGIN_COMMIT_OVERRIDE chore(ci3): add optional local cache for bootstrap artifacts (#20305) fix: Fix p2p integration test (#20331) chore: reduce fee log severity (#20336) feat: restrict response sizes to expected sizes (#20287) feat: retry web3signer connection (#20342) feat(p2p): Integrate TxPoolV2 across codebase (#20172) feat: review and optimize Claude configuration, agents, and skills (#20270) fix(prover): handle cross-chain messages when proving mbps (#20354) chore: retry flakes. if retry pass, is a flake as we know it now. fail both is hard fail (#19322) chore(p2p): add mock reqresp layer for tests (#20370) fix: (A-370) don't propagate on tx mempool add failure (#20374) chore: Skip the HA test (#20376) feat: Retain pruned transactions until pruned block is finalised (#20237) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were re-inserting cross chain messages in world state for every block in the checkpoint, where we only need to insert them on the first block.
This fixes it, and also extends the epochs-mbps e2e test suite to also assert that the multi-block checkpoints get properly proven.
Builds on #20351