Skip to content

feat: review and optimize Claude configuration, agents, and skills#20270

Merged
ludamad merged 8 commits intomerge-train/spartanfrom
ad/feat/review-optimize-claude-config
Feb 10, 2026
Merged

feat: review and optimize Claude configuration, agents, and skills#20270
ludamad merged 8 commits intomerge-train/spartanfrom
ad/feat/review-optimize-claude-config

Conversation

@ludamad
Copy link
Collaborator

@ludamad ludamad commented Feb 8, 2026

  • Have claude opus 4.6 go through and apply 'best practices'
  • Add nuance around when to squash/amend

@ludamad ludamad force-pushed the ad/feat/review-optimize-claude-config branch from 347db85 to 6b21035 Compare February 10, 2026 17:23
- Remove model: field from all agents (inherit from caller)
- Tighten agent output contracts (required sections, 200-line cap)
- Fix relative path in analyze-logs to use git rev-parse
- Replace pseudo-code Task() calls with natural language in ci-logs
- Remove checklist copy anti-patterns from noir-sync-update and updating-changelog
- Add Phase 0 PR validation guard to fix-pr (abort if PR not OPEN)
- Replace git add . with git add -u in fix-pr and rebase-pr
- Trim debug-e2e verbosity (~150 lines removed, deduplicated with analyze-logs agent)
- Add argument-hint to debug-e2e and worktree-spawn
@ludamad ludamad force-pushed the ad/feat/review-optimize-claude-config branch from 6b21035 to e5b2eee Compare February 10, 2026 17:46
- Set model: opus (not sonnet) in analyze-logs, identify-ci-failures, retrospective
- Update CLAUDE.md "Fixing PRs" to recommend normal commits during development,
  only amend when explicitly asked or via /fix-pr skill
@ludamad ludamad marked this pull request as ready for review February 10, 2026 17:52
@AztecBot
Copy link
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/c20fc0a6dd9acfbb�c20fc0a6dd9acfbb8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_mbps.parallel.test.ts "builds multiple blocks per slot with transactions anchored to proposed blocks" (244s) (code: 1) group:e2e-p2p-epoch-flakes

@ludamad ludamad changed the base branch from next to merge-train/spartan February 10, 2026 18:16
Copy link
Contributor

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd want to add something related to targeting merge-trains as base branches, but can leave that for another PR.

name: analyze-logs
description: |
Deep-read test logs and extract relevant information. Runs in separate context to avoid polluting the main conversation. Accepts local file paths (preferred) or hashes. Returns condensed summaries, not raw logs.
model: sonnet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💸

@ludamad ludamad changed the title feat: review and optimize Claude configuration, agents, and skills syste feat: review and optimize Claude configuration, agents, and skills Feb 10, 2026
@ludamad ludamad merged commit ea235ea into merge-train/spartan Feb 10, 2026
20 of 21 checks passed
@ludamad ludamad deleted the ad/feat/review-optimize-claude-config branch February 10, 2026 19:11
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2026
BEGIN_COMMIT_OVERRIDE
chore(ci3): add optional local cache for bootstrap artifacts (#20305)
fix: Fix p2p integration test (#20331)
chore: reduce fee log severity (#20336)
feat: restrict response sizes to expected sizes (#20287)
feat: retry web3signer connection (#20342)
feat(p2p): Integrate TxPoolV2 across codebase (#20172)
feat: review and optimize Claude configuration, agents, and skills
(#20270)
fix(prover): handle cross-chain messages when proving mbps (#20354)
chore: retry flakes. if retry pass, is a flake as we know it now. fail
both is hard fail (#19322)
chore(p2p): add mock reqresp layer for tests (#20370)
fix: (A-370) don't propagate on tx mempool add failure (#20374)
chore: Skip the HA test (#20376)
feat: Retain pruned transactions until pruned block is finalised
(#20237)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants