chore: retry flakes. if retry pass, is a flake as we know it now. fail both is hard fail#19322
Merged
ludamad merged 3 commits intomerge-train/spartanfrom Feb 10, 2026
Merged
chore: retry flakes. if retry pass, is a flake as we know it now. fail both is hard fail#19322ludamad merged 3 commits intomerge-train/spartanfrom
ludamad merged 3 commits intomerge-train/spartanfrom
Conversation
ludamad
approved these changes
Jan 5, 2026
Collaborator
|
I'm nervous about this as there's nothing to say e.g. webkit cant flake twice in a row. Right now we know it's busted but keep it as 'at least it doesn't always flake'. This is just a probabilistic reduction in pain as it will cause sporadic failures. I wonder if this can pass as-is. But willing to try it, LGTM |
ludamad
approved these changes
Jan 5, 2026
545b220 to
083250f
Compare
…st with retry-on-flake system
…into cl/retry_flakes
ludamad
approved these changes
Feb 10, 2026
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
BEGIN_COMMIT_OVERRIDE chore(ci3): add optional local cache for bootstrap artifacts (#20305) fix: Fix p2p integration test (#20331) chore: reduce fee log severity (#20336) feat: restrict response sizes to expected sizes (#20287) feat: retry web3signer connection (#20342) feat(p2p): Integrate TxPoolV2 across codebase (#20172) feat: review and optimize Claude configuration, agents, and skills (#20270) fix(prover): handle cross-chain messages when proving mbps (#20354) chore: retry flakes. if retry pass, is a flake as we know it now. fail both is hard fail (#19322) chore(p2p): add mock reqresp layer for tests (#20370) fix: (A-370) don't propagate on tx mempool add failure (#20374) chore: Skip the HA test (#20376) feat: Retain pruned transactions until pruned block is finalised (#20237) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes A-532.