Skip to content

chore: retry flakes. if retry pass, is a flake as we know it now. fail both is hard fail#19322

Merged
ludamad merged 3 commits intomerge-train/spartanfrom
cl/retry_flakes
Feb 10, 2026
Merged

chore: retry flakes. if retry pass, is a flake as we know it now. fail both is hard fail#19322
ludamad merged 3 commits intomerge-train/spartanfrom
cl/retry_flakes

Conversation

@charlielye
Copy link
Contributor

@charlielye charlielye commented Jan 5, 2026

Fixes A-532.

@charlielye charlielye requested a review from ludamad January 5, 2026 18:13
@ludamad
Copy link
Collaborator

ludamad commented Jan 5, 2026

I'm nervous about this as there's nothing to say e.g. webkit cant flake twice in a row. Right now we know it's busted but keep it as 'at least it doesn't always flake'. This is just a probabilistic reduction in pain as it will cause sporadic failures. I wonder if this can pass as-is.

But willing to try it, LGTM

@ludamad ludamad added ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure ci-full Run all master checks. labels Jan 15, 2026
@ludamad ludamad changed the base branch from next to merge-train/spartan February 10, 2026 19:45
@ludamad ludamad merged commit 548095b into merge-train/spartan Feb 10, 2026
22 of 23 checks passed
@ludamad ludamad deleted the cl/retry_flakes branch February 10, 2026 19:48
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2026
BEGIN_COMMIT_OVERRIDE
chore(ci3): add optional local cache for bootstrap artifacts (#20305)
fix: Fix p2p integration test (#20331)
chore: reduce fee log severity (#20336)
feat: restrict response sizes to expected sizes (#20287)
feat: retry web3signer connection (#20342)
feat(p2p): Integrate TxPoolV2 across codebase (#20172)
feat: review and optimize Claude configuration, agents, and skills
(#20270)
fix(prover): handle cross-chain messages when proving mbps (#20354)
chore: retry flakes. if retry pass, is a flake as we know it now. fail
both is hard fail (#19322)
chore(p2p): add mock reqresp layer for tests (#20370)
fix: (A-370) don't propagate on tx mempool add failure (#20374)
chore: Skip the HA test (#20376)
feat: Retain pruned transactions until pruned block is finalised
(#20237)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-full-no-test-cache ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants