Skip to content

feat: retry web3signer connection#20342

Merged
PhilWindle merged 1 commit intomerge-train/spartanfrom
mr/retry-web3signer-connection
Feb 10, 2026
Merged

feat: retry web3signer connection#20342
PhilWindle merged 1 commit intomerge-train/spartanfrom
mr/retry-web3signer-connection

Conversation

@mrzeszutko
Copy link
Contributor

Summary

  • Add retry logic with backoff to KeystoreManager.validateSigners() so that transient web3signer unavailability at boot time doesn't crash the node
  • Validate all web3signer URLs in parallel via Promise.all (previously serial), each wrapped in retry() with backoff intervals of [1, 2, 4, 8, 16] seconds (~31s total)
  • Add two new tests: one verifying errors propagate after retries are exhausted, one verifying transient failures are retried and eventually succeed

This is especially useful for test networks where web3signer and validators start simultaneously — the node no longer crashes if the signer takes a few seconds to become reachable.

Fixes A-444

@AztecBot
Copy link
Collaborator

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033FLAKED\033 (8;;http://ci.aztec-labs.com/f211972ad7edf53e�f211972ad7edf53e8;;�):  yarn-project/end-to-end/scripts/run_test.sh simple src/e2e_epochs/epochs_mbps.parallel.test.ts "builds multiple blocks per slot with transactions anchored to proposed blocks" (224s) (code: 1) group:e2e-p2p-epoch-flakes

@PhilWindle PhilWindle merged commit e5f63ca into merge-train/spartan Feb 10, 2026
15 of 16 checks passed
@PhilWindle PhilWindle deleted the mr/retry-web3signer-connection branch February 10, 2026 16:21
github-merge-queue bot pushed a commit that referenced this pull request Feb 11, 2026
BEGIN_COMMIT_OVERRIDE
chore(ci3): add optional local cache for bootstrap artifacts (#20305)
fix: Fix p2p integration test (#20331)
chore: reduce fee log severity (#20336)
feat: restrict response sizes to expected sizes (#20287)
feat: retry web3signer connection (#20342)
feat(p2p): Integrate TxPoolV2 across codebase (#20172)
feat: review and optimize Claude configuration, agents, and skills
(#20270)
fix(prover): handle cross-chain messages when proving mbps (#20354)
chore: retry flakes. if retry pass, is a flake as we know it now. fail
both is hard fail (#19322)
chore(p2p): add mock reqresp layer for tests (#20370)
fix: (A-370) don't propagate on tx mempool add failure (#20374)
chore: Skip the HA test (#20376)
feat: Retain pruned transactions until pruned block is finalised
(#20237)
END_COMMIT_OVERRIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants