chore(ci3): add optional local cache for bootstrap artifacts#20305
Merged
spalladino merged 2 commits intomerge-train/spartanfrom Feb 10, 2026
Merged
chore(ci3): add optional local cache for bootstrap artifacts#20305spalladino merged 2 commits intomerge-train/spartanfrom
spalladino merged 2 commits intomerge-train/spartanfrom
Conversation
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
ludamad
reviewed
Feb 9, 2026
ci3/cache_download
Outdated
|
|
||
| echo_stderr "Local cache miss for $tar_file, downloading from remote." | ||
|
|
||
| if [[ -n "${S3_BUILD_CACHE_AWS_PARAMS:-}" ]]; then |
Collaborator
There was a problem hiding this comment.
not a fan of this redundancy. extract a function?
Collaborator
|
mostly lgtm, just the one comment. we should be able to extract a function that puts the tar into stdout that can be used in both cases |
Contributor
Author
|
@ludamad done |
ludamad
approved these changes
Feb 10, 2026
Collaborator
|
Note that we don't really cache upload locally so that change isn't super necessary but I'm ok with it |
Should speed up bootstrap when changing back to a branch for which we had already downloaded artifacts.
spalladino
force-pushed
the
palla/ci3-local-cache
branch
from
a9a7713 to
0907b28
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
BEGIN_COMMIT_OVERRIDE chore(ci3): add optional local cache for bootstrap artifacts (#20305) fix: Fix p2p integration test (#20331) chore: reduce fee log severity (#20336) feat: restrict response sizes to expected sizes (#20287) feat: retry web3signer connection (#20342) feat(p2p): Integrate TxPoolV2 across codebase (#20172) feat: review and optimize Claude configuration, agents, and skills (#20270) fix(prover): handle cross-chain messages when proving mbps (#20354) chore: retry flakes. if retry pass, is a flake as we know it now. fail both is hard fail (#19322) chore(p2p): add mock reqresp layer for tests (#20370) fix: (A-370) don't propagate on tx mempool add failure (#20374) chore: Skip the HA test (#20376) feat: Retain pruned transactions until pruned block is finalised (#20237) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CACHE_LOCAL_DIRenv varCACHE_LOCAL_DIRis unset, behavior is identical to before (zero impact on CI or other devs)This reduces full bootstrap time from 165s to 77s by avoiding redundant S3 downloads for artifacts that haven't changed.
Usage
Test plan
ci3/cache_local.test.shwith 8 tests (12 assertions) covering: local cache hit/miss, upload save, roundtrip, disabled-cache bypass, inaccessible directory fallthroughrm -rfon any path derived fromCACHE_LOCAL_DIRbash ci3/cache_local.test.shto execute tests🤖 Generated with Claude Code