refactor: call args as an array instead of a slice#18417
Merged
Conversation
This was referenced Nov 14, 2025
Contributor
Author
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
75b4577 to
8ba41d6
Compare
benesjan
force-pushed
the
11-14-refactor_dropping_use_of_slices_from_calls
branch
2 times, most recently
from
71f23d5 to
fa41a20
Compare
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
2 times, most recently
from
2011739 to
14e7d4d
Compare
benesjan
force-pushed
the
11-14-refactor_dropping_use_of_slices_from_calls
branch
2 times, most recently
from
397ca53 to
5fd93f6
Compare
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
14e7d4d to
c8246fc
Compare
AztecBot
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
c8246fc to
24e5513
Compare
benesjan
force-pushed
the
11-14-refactor_dropping_use_of_slices_from_calls
branch
from
22b59bb to
ae1fd78
Compare
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
24e5513 to
05792c2
Compare
benesjan
requested review from
LeilaWang,
dbanks12,
fcarreiro and
sirasistant
as code owners
AztecBot
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
05792c2 to
47fbde1
Compare
Base automatically changed from
11-14-refactor_dropping_callinterface_trait
to
next
November 19, 2025 16:03
benesjan
force-pushed
the
11-14-refactor_dropping_use_of_slices_from_calls
branch
2 times, most recently
from
803e00b to
fc8919f
Compare
benesjan
force-pushed
the
11-14-refactor_dropping_use_of_slices_from_calls
branch
from
fc8919f to
72976c7
Compare
benesjan
commented
Nov 24, 2025
benesjan
commented
Nov 24, 2025
benesjan
commented
Nov 24, 2025
benesjan
changed the title
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
dbanks12
reviewed
Nov 24, 2025
Contributor
dbanks12
left a comment
dbanks12
left a comment
There was a problem hiding this comment.
Public context and avm transpiler stuff looks good to me!
mverzilli
reviewed
Nov 24, 2025
mverzilli
reviewed
Nov 24, 2025
mverzilli
reviewed
Nov 24, 2025
| }; | ||
|
|
||
| pub unconstrained fn add_private_authwit_from_call<T, let M: u32>( | ||
| pub unconstrained fn add_private_authwit_from_call<let M: u32, let N: u32, T>( |
Contributor
There was a problem hiding this comment.
Would be nice to have some comment briefly defining what M, N and T stand for. Or, if Noir allows, using more descriptive names for said type variables. eg: add_private_authwit_from_call<let CallNameLen: u32, ArgsLen: u32, CallReturnType>)
Contributor
Author
There was a problem hiding this comment.
You have a point but this is all over the place and it's a bit unrelated so doesn't make sense to do in this PR.
mverzilli
reviewed
Nov 24, 2025
| } | ||
|
|
||
| pub unconstrained fn add_public_authwit_from_call<T, let M: u32>( | ||
| pub unconstrained fn add_public_authwit_from_call<let M: u32, let N: u32, T>( |
mverzilli
approved these changes
Nov 24, 2025
Contributor
mverzilli
left a comment
mverzilli
left a comment
There was a problem hiding this comment.
Nice! Only general comment is I would try to use more descriptive names for parametric types (especially when a function or type ends up having more than one, like many cases in this PR where there's M, N and T).
I don't know if Noir supports names with more than letter in such cases though, so feel free to ignore me
Usage of slices is now discouraged and for this reason I am dropping their use from calls. This made me drop the `hash_args` function and rename `hash_args_array` to just `hash_args` as the original was no longer in use. Also `poseidon2_hash_with_separator_slice` got dropped due to lack of use.
AztecBot
force-pushed
the
11-14-refactor_dropping_use_of_slices_from_calls
branch
from
e73ead2 to
663806b
Compare
benesjan
deleted the
11-14-refactor_dropping_use_of_slices_from_calls
branch
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage of slices is now discouraged and for this reason I am dropping their use from calls.
This made me drop the
hash_argsfunction and renamehash_args_arrayto justhash_argsas the original was no longer in use. Alsoposeidon2_hash_with_separator_slicegot dropped due to lack of use.