feat: new external function call interface by benesjan · Pull Request #18274 · AztecProtocol/aztec-packages

benesjan · 2025-11-07T16:34:42Z

Fixes F-135

In this PR I implement the following API:

self.{call, view, enqueue, enqueue_view, enqueue_view_incognito, set_as_teardown, set_as_teardown_incognito}(MyContract::at(address).my_function(...args))

that can now be used instead of:

MyContract::at(address).my_function(...args).{call, view, enqueue, enqueue_view, enqueue_view_incognito, set_as_teardown, set_as_teardown_incognito}(self.context)

I've also updated all the places to use the new API.

Now self.context is used in contracts fairly rarely.

benesjan · 2025-11-07T16:35:03Z

benesjan · 2025-11-07T18:42:29Z

noir-projects/aztec-nr/aztec/src/context/call_interfaces.nr

@@ -51,68 +51,10 @@ where
        }
    }



The docs from this file were moved over to ContractSelf and I marked the functions as deprecated to point devs to the new API.

benesjan · 2025-11-07T18:42:56Z

noir-projects/aztec-nr/aztec/src/context/call_interfaces.nr

-    /// # Returns
-    /// * `T` - Whatever data the called function has returned.
-    ///
+    /// TODO(F-130): Drop this function. This should be present only on PrivateStaticCallInterface.


Will drop this function in a followup PR. It shouldn't exist.

benesjan · 2025-11-07T18:44:25Z

noir-projects/aztec-nr/aztec/src/contract_self.nr

    {
        emit_event_in_private(event, self.context, recipient, delivery_mode);
    }
+


The docs here are mostly a copy-paster from call_interfaces.nr. I just:

updated the arguments as they are different here,

added the Example section which I thought is important because devs might not know how tho get the CallInterface arg.

benesjan · 2025-11-07T18:52:32Z

noir-projects/noir-contracts/contracts/test/avm_test_contract/src/main.nr

     * General Opcodes
     ************************************************************************/
    #[external("public")]
+    #[view]


Needed to do this because where it's called it's called statically and the new API doesn't support calling of non-view function statically because self.view(...) expects PublicStaticCallInterface on the input and not PublicCallInterface.

benesjan · 2025-11-07T18:54:32Z

noir-projects/noir-contracts/contracts/test/avm_test_contract/src/main.nr

    #[external("private")]
    fn enqueue_public_from_private() {
-        AvmTest::at(self.address).set_opcode_u8().enqueue_view(self.context);
+        self.enqueue_self_static.set_opcode_u8();


The naming here is inconsistent. Somewhere we use "static" and somewhere we use "view". Noted that in the final renaming task.

benesjan · 2025-11-07T21:00:21Z

noir-projects/noir-contracts/contracts/test/avm_test_contract/src/main.nr


+    #[external("public")]
+    #[view]
+    fn set_opcode_u8_view() -> u8 {


The new API doesn't allow me to call non-view function statically but we also need the set_opcode_u8 to be non-static for typescript test so I just created this copy here.

AztecBot · 2025-11-09T13:45:45Z

Flakey Tests

🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry.

\033[38;2;188;109;208mFLAKED\033[0m (\033[38;2;250;217;121m8;;http://ci.aztec-labs.com/9a4d2ddb3a46072f�9a4d2ddb3a46072f8;;�\033[0m): BOX=react BROWSER=firefox run_compose_test react-firefox box boxes (61s) (code: 1) (\033[38;2;188;109;208mAztec Bot\033[0m: feat: new external function call interface (#18274))

nventuro

Best jan ever

Fixes F-135 In this PR I implement the following API: ```rust self.{call, view, enqueue, enqueue_view, enqueue_view_incognito, set_as_teardown, set_as_teardown_incognito}(MyContract::at(address).my_function(...args)) ``` that can now be used instead of: ```rust MyContract::at(address).my_function(...args).{call, view, enqueue, enqueue_view, enqueue_view_incognito, set_as_teardown, set_as_teardown_incognito}(self.context) ``` I've also updated all the places to use the new API. Now `self.context` is used in contracts fairly rarely.

This was referenced Nov 7, 2025

refactor!: new aztec command #17792

Merged

feat: introducing #[internal] #17963

Merged

feat: panicking on direct calls to external funcs #18126

Merged

benesjan mentioned this pull request Nov 7, 2025

refactor: cleaning up flow of calls generation #18265

Merged

benesjan commented Nov 7, 2025

View reviewed changes

benesjan marked this pull request as ready for review November 7, 2025 18:55

benesjan force-pushed the 11-07-feat_new_external_function_call_interface branch from 548002b to baf4cef Compare November 7, 2025 20:21

benesjan force-pushed the 11-07-refactor_cleaning_up_flow_of_call_interface_generation branch from 5c45a7f to e9e3a26 Compare November 7, 2025 20:21

benesjan commented Nov 7, 2025

View reviewed changes

benesjan marked this pull request as draft November 8, 2025 22:17

benesjan force-pushed the 11-07-feat_new_external_function_call_interface branch from 1448ef8 to 9f627cf Compare November 8, 2025 22:18

benesjan force-pushed the 11-07-refactor_cleaning_up_flow_of_call_interface_generation branch from e9e3a26 to dc586db Compare November 8, 2025 22:18

benesjan force-pushed the 11-07-feat_new_external_function_call_interface branch from 9f627cf to 22ad496 Compare November 8, 2025 22:32

benesjan force-pushed the 11-07-refactor_cleaning_up_flow_of_call_interface_generation branch 2 times, most recently from 5843610 to ffe6c15 Compare November 8, 2025 23:16

benesjan force-pushed the 11-07-feat_new_external_function_call_interface branch 2 times, most recently from 4645315 to 1b0eb6f Compare November 8, 2025 23:31

benesjan mentioned this pull request Nov 8, 2025

refactor: restructuring function macros + migration notes #18289

Merged

benesjan force-pushed the 11-07-refactor_cleaning_up_flow_of_call_interface_generation branch from 6eedab5 to cc4088d Compare November 9, 2025 13:06

benesjan force-pushed the 11-07-feat_new_external_function_call_interface branch from 1b0eb6f to 50e1222 Compare November 9, 2025 13:06

benesjan marked this pull request as ready for review November 9, 2025 13:27

nventuro approved these changes Nov 10, 2025

View reviewed changes

benesjan force-pushed the 11-07-feat_new_external_function_call_interface branch from 8bb0e31 to 4463791 Compare November 10, 2025 14:48

benesjan force-pushed the 11-07-refactor_cleaning_up_flow_of_call_interface_generation branch from cc4088d to 09bfcdb Compare November 10, 2025 14:48

benesjan marked this pull request as draft November 10, 2025 14:50

benesjan force-pushed the 11-07-refactor_cleaning_up_flow_of_call_interface_generation branch from 09bfcdb to afc0612 Compare November 10, 2025 15:52

benesjan force-pushed the 11-07-feat_new_external_function_call_interface branch from 4463791 to 39a98d3 Compare November 10, 2025 15:52

AztecBot force-pushed the 11-07-refactor_cleaning_up_flow_of_call_interface_generation branch from afc0612 to e82cde7 Compare November 10, 2025 16:14

Base automatically changed from 11-07-refactor_cleaning_up_flow_of_call_interface_generation to next November 10, 2025 18:03

benesjan force-pushed the 11-07-feat_new_external_function_call_interface branch from 39a98d3 to 26b8165 Compare November 10, 2025 18:12

benesjan marked this pull request as ready for review November 10, 2025 18:13

benesjan added the ci-squash-and-merge label Nov 10, 2025

AztecBot force-pushed the 11-07-feat_new_external_function_call_interface branch from 26b8165 to 7de49f6 Compare November 10, 2025 18:38

AztecBot removed the ci-squash-and-merge label Nov 10, 2025

AztecBot enabled auto-merge November 10, 2025 18:38

AztecBot added this pull request to the merge queue Nov 10, 2025

auto-merge was automatically disabled November 10, 2025 18:49
Pull Request is not mergeable

Merged via the queue into next with commit 0ed91fa Nov 10, 2025
16 checks passed

AztecBot deleted the 11-07-feat_new_external_function_call_interface branch November 10, 2025 20:01

This was referenced Nov 13, 2025

refactor!: prohibiting static calls via non-static interface #18398

Merged

feat: panicking on incorrectly performed calls #18396

Merged

refactor: CallInterface cleanup #18413

Merged

refactor: call args as an array instead of a slice #18417

Merged

ludamad pushed a commit that referenced this pull request Dec 16, 2025

feat: new external function call interface (#18274)

f83542b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: new external function call interface#18274

feat: new external function call interface#18274
AztecBot merged 1 commit intonextfrom
11-07-feat_new_external_function_call_interface

benesjan commented Nov 7, 2025 •

edited

Loading

Uh oh!

benesjan commented Nov 7, 2025 •

edited

Loading

Uh oh!

benesjan Nov 7, 2025

Uh oh!

benesjan Nov 7, 2025

Uh oh!

benesjan Nov 7, 2025

Uh oh!

benesjan Nov 7, 2025

Uh oh!

benesjan Nov 7, 2025

Uh oh!

benesjan Nov 7, 2025

Uh oh!

AztecBot commented Nov 9, 2025 •

edited

Loading

Uh oh!

nventuro left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

benesjan commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benesjan commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benesjan Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

benesjan Nov 7, 2025

Choose a reason for hiding this comment

Uh oh!

AztecBot commented Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Flakey Tests

Uh oh!

nventuro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

benesjan commented Nov 7, 2025 •

edited

Loading

benesjan commented Nov 7, 2025 •

edited

Loading

AztecBot commented Nov 9, 2025 •

edited

Loading