Conversation
Contributor
Author
benesjan
force-pushed
the
11-13-refactor_prohibiting_static_calls_via_non-static_interface
branch
from
223f04c to
e16aacb
Compare
benesjan
changed the base branch from
graphite-base/18398
to
11-08-refactor_restructuring_function_macros
This was referenced Nov 13, 2025
benesjan
force-pushed
the
11-13-refactor_prohibiting_static_calls_via_non-static_interface
branch
2 times, most recently
from
159931f to
f9a6e22
Compare
benesjan
commented
Nov 13, 2025
| returns_hash.get_preimage() | ||
| } | ||
|
|
||
| /// TODO(F-130): Drop this function. This should be present only on PrivateStaticCallInterface. |
Contributor
Author
There was a problem hiding this comment.
Not closing this issue with this PR as there are more subtasks TODO
benesjan
commented
Nov 13, 2025
| arg_a: Field, | ||
| arg_b: Field, | ||
| ) -> Field { | ||
| AvmTest::at(address).add_args_return(arg_a, arg_b).view(context) |
Contributor
Author
There was a problem hiding this comment.
The test here relies on the static call but in other places another ugly stale monstrosity expects the called function to b e non-view so I hack around this by directly using the context thingy.
benesjan
commented
Nov 13, 2025
| // Indirectly call_static `set_storage_single`. Should revert since it's accessing self.storage. | ||
| #[external("public")] | ||
| fn nested_static_call_to_set_storage() { | ||
| AvmTest::at(self.address).set_storage_single(20).view(self.context); |
Contributor
Author
There was a problem hiding this comment.
The test here relies on the static call but in other places another ugly stale monstrosity expects the called function to b e non-view so I hack around this by directly using the context thingy.
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Thunkar
approved these changes
Nov 14, 2025
This was referenced Nov 14, 2025
benesjan
force-pushed
the
11-13-refactor_prohibiting_static_calls_via_non-static_interface
branch
from
b8f587e to
caf1409
Compare
benesjan
force-pushed
the
11-08-refactor_restructuring_function_macros
branch
from
38b4974 to
296e47c
Compare
AztecBot
force-pushed
the
11-08-refactor_restructuring_function_macros
branch
from
296e47c to
ecd4088
Compare
Base automatically changed from
11-08-refactor_restructuring_function_macros
to
next
November 18, 2025 17:58
benesjan
force-pushed
the
11-13-refactor_prohibiting_static_calls_via_non-static_interface
branch
from
caf1409 to
df09690
Compare
benesjan
changed the title
Fixes F-130 Allowing for this was sad and ugly so I dropped it.
AztecBot
force-pushed
the
11-13-refactor_prohibiting_static_calls_via_non-static_interface
branch
from
df09690 to
23bc889
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
benesjan
deleted the
11-13-refactor_prohibiting_static_calls_via_non-static_interface
branch
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F-130
Allowing for this was sad and ugly so I dropped it.