refactor: cleaning up flow of calls generation#18265
Merged
Conversation
This was referenced Nov 7, 2025
Contributor
Author
benesjan
changed the title
benesjan
changed the base branch from
10-24-feat_introducing_internal_
to
graphite-base/18265
benesjan
force-pushed
the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
from
fd553a2 to
d2467ff
Compare
benesjan
changed the base branch from
graphite-base/18265
to
10-24-feat_introducing_internal_
benesjan
commented
Nov 7, 2025
| @@ -4,10 +4,7 @@ | |||
| //! | |||
Contributor
Author
There was a problem hiding this comment.
Moved it from functions dir as it no longer made sense to have it there.
I want the functions dir to only contain the simple marker attributes and to move all the complex logic out of there.
benesjan
commented
Nov 7, 2025
| @@ -39,10 +34,6 @@ comptime fn get_abi_relevant_attributes(f: FunctionDefinition) -> Quoted { | |||
| } | |||
|
|
|||
| pub(crate) comptime fn transform_private(f: FunctionDefinition) -> Quoted { | |||
Contributor
Author
There was a problem hiding this comment.
These functions now became cleaner as the registration really had nothing to do here. I plan on renaming these functions to generate_{private,public,utility}_external to follow the naming of generate_{private,public}_internal and
benesjan
commented
Nov 7, 2025
| // We generate structs and their implementations necessary for convenient functions calls. | ||
| let interface = generate_contract_interface(m); | ||
| let self_call_structs = generate_self_call_structs(m); | ||
| let self_call_structs = generate_external_function_self_calls_structs(m); |
Contributor
Author
There was a problem hiding this comment.
Somewhat unrelated but felt like the original function name was no longer descriptive enough.
benesjan
commented
Nov 7, 2025
| /// `self.enqueue_self.some_public_function(args)` | ||
| /// - `EnqueueSelfStatic`: Enqueue your own view public functions, e.g.: | ||
| /// `self.enqueue_self_static.some_view_function(args)` | ||
| comptime fn generate_self_call_structs(m: Module) -> Quoted { |
Contributor
Author
There was a problem hiding this comment.
Replaced with calls_generation::external_functions::generate_external_function_self_calls_structs
benesjan
commented
Nov 7, 2025
| @@ -1,3 +1,6 @@ | |||
| // TODO(benesjan): Instead of having this registry, just generate the authorize check when the given | |||
| // `__aztec_nr_internals__` function is being generated. Having this registry is completely unnecessary. | |||
Contributor
Author
There was a problem hiding this comment.
This registry is also unnecessary. Plan on tackling this once the stack is merged. (will go through all the "TODO(benesjan)" in the codebase once that's done and do the cleanups).
benesjan
force-pushed
the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
from
5c45a7f to
e9e3a26
Compare
benesjan
force-pushed
the
10-24-feat_introducing_internal_
branch
from
a541e1f to
8a87c75
Compare
benesjan
force-pushed
the
10-24-feat_introducing_internal_
branch
from
8a87c75 to
58d83ff
Compare
benesjan
force-pushed
the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
2 times, most recently
from
dc586db to
5843610
Compare
benesjan
force-pushed
the
10-24-feat_introducing_internal_
branch
2 times, most recently
from
803e713 to
f59e55f
Compare
benesjan
force-pushed
the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
from
5843610 to
ffe6c15
Compare
benesjan
force-pushed
the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
from
6eedab5 to
cc4088d
Compare
benesjan
force-pushed
the
10-24-feat_introducing_internal_
branch
from
f59e55f to
8ba4963
Compare
Collaborator
Flakey Tests🤖 says: This CI run detected 2 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
benesjan
changed the base branch from
10-24-feat_introducing_internal_
to
graphite-base/18265
nventuro
approved these changes
Nov 10, 2025
benesjan
force-pushed
the
graphite-base/18265
branch
from
8ba4963 to
571f69f
Compare
benesjan
force-pushed
the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
from
cc4088d to
09bfcdb
Compare
benesjan
changed the base branch from
graphite-base/18265
to
10-24-feat_introducing_internal_
AztecBot
force-pushed
the
10-24-feat_introducing_internal_
branch
2 times, most recently
from
fd11b14 to
7241673
Compare
benesjan
force-pushed
the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
from
09bfcdb to
afc0612
Compare
Before this PR we generate the external function calls when the external macro was run and then we added the result to registries for later to be obtained by the aztec macro. This flow became unnecessarily complex because now the external macro just registers the function definitions in the external function registry and then it uses this registry to generate the `__aztec_nr_internals__` functions in the aztec macro. We can use this same function registry also for generating the calls obviating the need for the call registries.
AztecBot
force-pushed
the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
from
afc0612 to
e82cde7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2025
Before this PR we generate the external function calls when the external macro was run and then we added the result to registries for later to be obtained by the aztec macro. This flow became unnecessarily complex because now the external macro just registers the function definitions in the external function registry and then it uses this registry to generate the `__aztec_nr_internals__` functions in the aztec macro. We can use this same function registry also for generating the calls obviating the need for the call registries.
benesjan
deleted the
11-07-refactor_cleaning_up_flow_of_call_interface_generation
branch
This was referenced Nov 13, 2025
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR we generate the external function calls when the external macro was run and then we added the result to registries for later to be obtained by the aztec macro.
This flow became unnecessarily complex because now the external macro just registers the function definitions in the external function registry and then it uses this registry to generate the
__aztec_nr_internals__functions in the aztec macro. We can use this same function registry also for generating the calls obviating the need for the call registries.