Merged
Conversation
This was referenced Nov 14, 2025
Contributor
Author
This was referenced Nov 14, 2025
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
75b4577 to
8ba41d6
Compare
benesjan
force-pushed
the
11-13-feat_panicking_on_incorrectly_performed_calls
branch
from
d16b4e8 to
8ac9d75
Compare
benesjan
changed the title
CallInterface cleanup
benesjan
commented
Nov 14, 2025
Comment on lines
+15
to
+19
| pub target_contract: AztecAddress, | ||
| pub selector: FunctionSelector, | ||
| pub name: str<M>, | ||
| args_hash: Field, | ||
| args: [Field], | ||
| pub args: [Field], |
Contributor
Author
There was a problem hiding this comment.
Instead of having the getters here I just expose these as the getters were too boilerplate-y.
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
8ba41d6 to
2011739
Compare
benesjan
force-pushed
the
11-13-feat_panicking_on_incorrectly_performed_calls
branch
2 times, most recently
from
778be66 to
efcd7c4
Compare
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
2011739 to
14e7d4d
Compare
AztecBot
force-pushed
the
11-13-feat_panicking_on_incorrectly_performed_calls
branch
from
efcd7c4 to
99ae17c
Compare
Base automatically changed from
11-13-feat_panicking_on_incorrectly_performed_calls
to
next
November 19, 2025 13:06
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
14e7d4d to
c8246fc
Compare
AztecBot
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
c8246fc to
24e5513
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
benesjan
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
24e5513 to
05792c2
Compare
The complexity of the changes in this PR has been low so I decided to do a few things in one go: 1. Drop the `CallInterface` trait as it was not needed, 2. drop the call interface name and just use call, 3. dropped `is_static` from the static as its presence was bizarre (why does `PrivateCall` have `is_static` when there is another `PrivateStaticCall` struct?)
AztecBot
force-pushed
the
11-14-refactor_dropping_callinterface_trait
branch
from
05792c2 to
47fbde1
Compare
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The complexity of the changes in this PR has been low so I decided to do a few things in one go:
CallInterfacetrait as it was not needed,is_staticfrom the static as its presence was bizarre (why doesPrivateCallhaveis_staticwhen there is anotherPrivateStaticCallstruct?)