Skip to content

fix(data): correct Scenarii proper noun + strip BOM - #296

Merged
jsboige merged 1 commit into
masterfrom
data/scenarii-proper-noun-fix
May 17, 2026
Merged

fix(data): correct Scenarii proper noun + strip BOM#296
jsboige merged 1 commit into
masterfrom
data/scenarii-proper-noun-fix

Conversation

@jsboige

@jsboige jsboige commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Context

Identified during ai-01's i18n audit (cycle 32/33). "Olympe de Gouges" was mistranslated as "Olympus of Gouge" (mountain) instead of recognizing her as a suffragette. PT had "Um sufrágio" (a suffrage/vote) instead of "Uma sufragista" (a suffragette).

Test plan

  • Verified fix by row identity (titre field match)
  • BOM stripped from both files confirmed by byte inspection
  • Pipeline run should show no regressions

🤖 Generated with Claude Code

@clusterManager-Myia clusterManager-Myia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two fixes in one PR:

  1. BOM removal: Strips UTF-8 BOM from both Virtues and Scenarii CSVs (introduced by earlier PRs). Correct fix — removes the BOM I flagged in reviews #291/#292/#293.
  2. Translation fix: Row 1.2.4 (Le droit de vote des femmes):
    • EN drawer: "Olympus of Gouge" → "A suffragette" — correct, Olympe de Gouges was a historical suffragette, not a mountain
    • PT drawer_pt: "Um sufrágio" → "Uma sufragista" — correct Portuguese for "a suffragette"

Clean, minimal diff. Should merge after #294 and #295.

@jsboige jsboige left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review ai-01 — cycle 36

Verdict : 🟢 APPROVE (comment) — fix surgical reprenant exactement les findings cycles 31/32/35.

Convention checklist

  • ✅ Diff sanity : +3/-3, 2 fichiers, ultra-surgical
  • ✅ Format CSV : header propre post-BOM strip
  • ✅ No FR regression : aucune cellule FR touchée
  • ✅ Sample qualité (3/3) :
    • Scenarii 1.2.4 drawer EN : "Olympus of Gouge" → "A suffragette" ✓ corrige finding #9 cycle 31
    • Scenarii 1.2.4 drawer_pt : "Um sufrágio" → "Uma sufragista" ✓ corrige finding cycle 32
    • Virtues + Scenarii : BOM stripped ✓ corrige note cycle 35
  • ✅ CI verts : Build Debug + Release + GitGuardian SUCCESS

Note de scope

Reste du record 1.2.4 PT toujours bugué (hors scope) : context_pt "os sufrágios trabalham", issue_pt "O baratinener", suggestion_pt "ter o único". Font partie du chantier finding #11.

🤖 Generated with Claude Code

- Scenarii row 9 (path 1.2.4): "Olympus of Gouge" → "A suffragette" (EN drawer)
- Scenarii row 9 (path 1.2.4): "Um sufrágio" → "Uma sufragista" (PT drawer_pt)
- Strip UTF-8 BOM from Virtues CSV (introduced by PR #290)
- Strip UTF-8 BOM from Scenarii CSV (introduced by PR #291)

Olympe de Gouges is a French historical figure (suffragette), not a mountain.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jsboige
jsboige force-pushed the data/scenarii-proper-noun-fix branch from 23b7668 to f616032 Compare May 17, 2026 15:13
@jsboige
jsboige merged commit 8e3a6aa into master May 17, 2026
3 checks passed
jsboige added a commit that referenced this pull request May 17, 2026
…rmalize-296-regression

fix(data): restore Scenarii normalize lost in PR #296 regression
@jsboige
jsboige deleted the data/scenarii-proper-noun-fix branch June 1, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants