fix(data): correct Scenarii proper noun + strip BOM - #296
Merged
Conversation
clusterManager-Myia
approved these changes
May 17, 2026
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
Two fixes in one PR:
- BOM removal: Strips UTF-8 BOM from both Virtues and Scenarii CSVs (introduced by earlier PRs). Correct fix — removes the BOM I flagged in reviews #291/#292/#293.
- Translation fix: Row 1.2.4 (Le droit de vote des femmes):
- EN
drawer: "Olympus of Gouge" → "A suffragette" — correct, Olympe de Gouges was a historical suffragette, not a mountain - PT
drawer_pt: "Um sufrágio" → "Uma sufragista" — correct Portuguese for "a suffragette"
- EN
jsboige
commented
May 17, 2026
jsboige
left a comment
Contributor
Author
There was a problem hiding this comment.
Review ai-01 — cycle 36
Verdict : 🟢 APPROVE (comment) — fix surgical reprenant exactement les findings cycles 31/32/35.
Convention checklist
- ✅ Diff sanity : +3/-3, 2 fichiers, ultra-surgical
- ✅ Format CSV : header propre post-BOM strip
- ✅ No FR regression : aucune cellule FR touchée
- ✅ Sample qualité (3/3) :
- Scenarii 1.2.4 drawer EN : "Olympus of Gouge" → "A suffragette" ✓ corrige finding #9 cycle 31
- Scenarii 1.2.4 drawer_pt : "Um sufrágio" → "Uma sufragista" ✓ corrige finding cycle 32
- Virtues + Scenarii : BOM stripped ✓ corrige note cycle 35
- ✅ CI verts : Build Debug + Release + GitGuardian SUCCESS
Note de scope
Reste du record 1.2.4 PT toujours bugué (hors scope) : context_pt "os sufrágios trabalham", issue_pt "O baratinener", suggestion_pt "ter o único". Font partie du chantier finding #11.
🤖 Generated with Claude Code
- Scenarii row 9 (path 1.2.4): "Olympus of Gouge" → "A suffragette" (EN drawer) - Scenarii row 9 (path 1.2.4): "Um sufrágio" → "Uma sufragista" (PT drawer_pt) - Strip UTF-8 BOM from Virtues CSV (introduced by PR #290) - Strip UTF-8 BOM from Scenarii CSV (introduced by PR #291) Olympe de Gouges is a French historical figure (suffragette), not a mountain. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jsboige
force-pushed
the
data/scenarii-proper-noun-fix
branch
from
May 17, 2026 15:13
23b7668 to
f616032
Compare
4 tasks
jsboige
added a commit
that referenced
this pull request
May 17, 2026
…rmalize-296-regression fix(data): restore Scenarii normalize lost in PR #296 regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
drawer"Olympus of Gouge" → "A suffragette" — Olympe de Gouges is a French historical figure, not a mountaindrawer_pt"Um sufrágio" → "Uma sufragista" — correct Portuguese for "a suffragette"Context
Identified during ai-01's i18n audit (cycle 32/33). "Olympe de Gouges" was mistranslated as "Olympus of Gouge" (mountain) instead of recognizing her as a suffragette. PT had "Um sufrágio" (a suffrage/vote) instead of "Uma sufragista" (a suffragette).
Test plan
titrefield match)🤖 Generated with Claude Code