fix(data): restore Scenarii normalize lost in PR #296 regression - #300
Merged
Merged
Conversation
PR #296 (data/scenarii-proper-noun-fix) was branched from #291 instead of master post-#294. When merged, it silently overwrote PR #294's category/ subcategory normalization work across all 167 rows. Damage from #296 merge (master HEAD pre-fix): - TitleCase category EN: 167/167 -> 25/167 (-142 reverts) - TitleCase subcategory EN: 162/167 -> 19/167 (-143 reverts) - EMPTY category EN: 0/167 -> 74/167 (+74 cells re-emptied) This commit restores #294's normalized state and preserves #296's intentional fixes: - Row 1.2.4 drawer EN: "Olympus of Gouge" -> "A suffragette" - Row 1.2.4 drawer_pt: "Um sufragio" -> "Uma sufragista" - No BOM (already absent in #294, #296 BOM strip only mattered for Virtues) Pattern: same silent regression as #228 -> #233 (memorized). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
clusterManager-Myia
approved these changes
May 17, 2026
clusterManager-Myia
left a comment
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
APPROVE — correct regression fix.
Verified: PR #296 branched from pre-#294 state, silently overwrote 142 TitleCase EN categories + created 74 empty cells. This PR restores PR #294's normalization and preserves PR #296's proper noun fixes (row 1.2.4: suffragette/sufragista).
Sampled row 1.2.4: history,antiquity → History,Middle Ages and modern era. Correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #296 (
data/scenarii-proper-noun-fix) was branched from PR #291 (2b0de3ae) instead of master post-#294. When merged at 16:40 (5 min after #294), it silently overwrote PR #294's normalization work because the diff was a full-file replacement (167 insertions / 167 deletions).This PR restores #294's normalized state on top of current master and preserves #296's intentional fixes.
Damage quantified (master HEAD pre-fix vs PR #294 final)
Visible regression examples on master before this PR:
history,antiquity(lowercase)category,subcategorycellsAntiguidadesubcategory_pt fill from data(scenarii): normalize EN/RU/PT category/subcategory translations #294What this PR does
fb5dd843(PR data(scenarii): normalize EN/RU/PT category/subcategory translations #294 final state)"Olympus of Gouge"→"A suffragette""Um sufrágio"→"Uma sufragista"Verification
Post-fix state (this branch):
Pattern recognition
Same silent regression pattern as #228 → #233 (memorized in ai-01 feedback memory
feedback_merge_cross_check_audit.md). Cross-checking merge HEAD vs PR mergeCommit after concurrent rebases caught this within 24 h.Test plan
dotnet testpasses (CsvHelper parse OK)🤖 Generated with Claude Code