Skip to content

docs(audit): measure and rule the 24 UNRESOLVED fork-PR rows (t_63023f77) - #1186

Merged
ang-fleet-lander[bot] merged 2 commits into
mainfrom
audit/unresolved-rulings
Sep 27, 2026
Merged

ang-fleet-lander[bot] merged 2 commits into
mainfrom
audit/unresolved-rulings

Conversation

@Kyzcreig

@Kyzcreig Kyzcreig commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up to #1128 (ROLLUP §9). Stacked on audit/final, docs only.

Takes the missing measurement for each of the 24 UNRESOLVED rows, then rules on it with the README §2 protocol.

  • Verdicts: DROP 10, KEEP 8, UPSTREAM 4, SUPERSEDED-BY-UPSTREAM 2.
  • Slice cards: 14 filed for the changed rows (ids are in the doc's card column).
  • Every row's measurement, with its time window, is in docs/plans/fork-pr-audit/UNRESOLVED.md.

Card: t_63023f77


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Kyzcreig added a commit that referenced this pull request Sep 26, 2026
Reverts e1de835. Fork-PR audit UNRESOLVED ruling (t_63023f77,
#1186): the trigger is whitespace in a
home/interpreter/skill-category/plugin path; measured 0 occurrences on
both fleet hosts, so the hints never needed quoting here. The gateway/run.py
hunk conflicted in all 3 upstream syncs.

Kept: #889's hermes_cli.cli_hint.hint_value and its callers (KEEP row).
gateway/run.py conflict resolved by keeping current main's
_skill_slug_index loop and dropping only the hint_value() wrap.

Card: t_ceb111f9
Base automatically changed from audit/final to main September 26, 2026 09:46
Each row gets the measurement the lead lacked, then a README section 2 verdict:
DROP 10, KEEP 8, UPSTREAM 4, SUPERSEDED-BY-UPSTREAM 2.
14 slice cards were filed for the rows whose verdict changed.

Verified: probes on clean fork 858ee59 and upstream c15ebb1 worktrees
with a temp home, read-only state.db/kanban.db queries, log greps, a live CDP
repro on Chrome 154, and REST merge-queue job-log counts for #695.
Narrow fork tests via test-gate: 175 passed.
@Kyzcreig
Kyzcreig force-pushed the audit/unresolved-rulings branch from 507ef2b to 60c54e3 Compare September 27, 2026 13:03
@ang-fleet-lander

Copy link
Copy Markdown

🤖 merged-by: apollo · lane: kanban-merge-pass · gate: ADVISORY (FleetReview not green for 1e7b617): fleetreview-advisory-20260927-standing.md · why: t_12b66b00: fork-PR audit: fold the 24 rulings that fork #1186 added as files into lead/rows; Argus off card review (Ace 13:08), CI green

@ang-fleet-lander
ang-fleet-lander Bot added this pull request to the merge queue Sep 27, 2026
Merged via the queue into main with commit df03cae Sep 27, 2026
31 checks passed
@ang-fleet-lander
ang-fleet-lander Bot deleted the audit/unresolved-rulings branch September 27, 2026 14:19
@ang-fleet-ci-actuators ang-fleet-ci-actuators Bot added the fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent) label Sep 27, 2026
@ang-prism

ang-prism Bot commented Sep 27, 2026

Copy link
Copy Markdown

FleetReview

Review: post-merge · head df03cae6a0ae · duration 5m 06s
Profile: full recipe · policy: below-size-and-path-gates
Roster: B-assert-ctx → gpt-6-sol (openai), B-state → gpt-6-sol (openai), C-assert-xhigh → claude-code-opus-5-5 (anthropic), F → gpt-6-sol (openai), G → grok-4.6 (xai), L6 → gpt-6-sol (openai)

Post-merge review (fleetreview:post-merge override): this reviewed the merge commit against its first parent — the bytes that already shipped. It is not a pre-merge gate pass.

Confidence: 3/5

Findings

  • P1 docs/plans/fork-pr-audit/UNRESOLVED.md:38 — Unmeasured Submits · agreed: B-assert-ctx (openai)
  • P1 docs/plans/fork-pr-audit/unresolved.verdicts.json:63 — Unmeasured Rejections · agreed: B-assert-ctx (openai)
  • P1 docs/plans/fork-pr-audit/UNRESOLVED.md:44 — Do not use source='tui' sessions to justify dropping the empty-submit guard · agreed: F (openai)

FleetReview provenance · models: B=gpt-6-sol, C=claude-code-opus-5-5, D=grok-4.6, F=gpt-6-sol · cost: $1.89 · duration: 5m 04s · rounds: 1 · files examined: 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fleetreview:post-merge Ask FleetReview to review this MERGED pull (merge commit vs first parent)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant