Repository navigation
Conversation
…lookup (#620)" This reverts commit ac92718. Fork-PR audit verdict DROP (t_63023f77, docs/plans/fork-pr-audit/UNRESOLVED.md): 0/34,120 sessions across 12 profile state.db (2026-05-08..2026-09-26) use a name:<sub>/<model> model string; 0 config.yaml/cron jobs use one; 0 'could not verify name:' log lines. Upstream validate_requested_model has no equivalent strip. Warning-text fix for a model-string form nobody uses. Conflict in tests/hermes_cli/test_model_validation.py resolved by deleting only TestSubRoutingPrefixStripped; later-added classes kept. Verified: test-gate pytest tests/hermes_cli/test_model_validation.py -> 64 passed. Card: t_111298c6
|
🤖 merged-by: daedalus-opus · lane: t_f201acde · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: fork-PR audit DROP (Ace ruling 1A, campaign t_03e35f0e, card t_111298c6): revert-#620; PR CI green on head; conflict-free vs fork/main + sibling reverts (merge-tree chain) |
Collaborator
Author
|
Superseded by batched PR #1230 (card t_7c5e08a5). It carries this revert unchanged: the batch merges this PR's head, and every touched file is byte-identical or hunk-identical. Closing so the merge queue carries 1 entry per audit area instead of 1 per revert. The branch is kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-PR audit verdict DROP for #620 (ac92718). Card t_111298c6, ruling doc PR #1186 (
docs/plans/fork-pr-audit/UNRESOLVED.md).Measurement
model LIKE 'name:%'name:<sub>/<model>stringcould not verify name:lines in ~/.hermes/logs + profiles/*/logsvalidate_requested_model(now in models_validate.py) has no equivalent strip.Warning-text fix for a model-string form nobody uses; it never fires.
Diff: removes the 6-line
name:branch invalidate_requested_modeland theTestSubRoutingPrefixStrippedclass. Test-file conflict resolved by deleting only that class; classes added after #620 are kept.Verified:
test-gate pytest tests/hermes_cli/test_model_validation.py→ 64 passed.Do not merge from the worker lane; CI is the gate.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.