Repository navigation
Conversation
…#441) Reverts 66d98d3 (#215) and its re-land 0986938 (#441) as one unit, per the fork-PR audit UNRESOLVED ruling (DROP, t_63023f77 / t_7c17872a). Removed: - hermes_cli/session_db_heavy_gate.py (SessionDBHeavyReadBusy, the slot, stats, lazy dashboard.heavy_read_max_concurrency read) - tui_gateway/ws.py: gate import + _dispatch_ws_request; WS requests go back to asyncio.to_thread(server.dispatch, ...) - tui_gateway/server.py: _SESSION_DB_HEAVY_METHODS, is_session_db_heavy_method, backend_busy_error, handle_request_bound (_err's data= param kept: methods_prompt/methods_bot_relay use it) - hermes_cli/web_server.py: gate import, 503 shed handler and the /api/status session_db_heavy_reads field; _session_db_read(heavy=True) returns to the pre-#215 per-loop asyncio.Semaphore(2) - config_defaults: dashboard.heavy_read_max_concurrency - gate tests in tests/test_web_server_sessiondb_eventloop.py and tests/scripts/test_preyield_permit_release.py; the guard script's live-site list. The guard sweep keeps a live site (gateway/turn_admission.py) and its named coverage test. Why: 0 'session_db_heavy_read' log lines across ~/.hermes/logs and profiles/*/logs (no read ever queued >= 1 ms); 473/474 loc across 5 files conflicting in all 3 upstream syncs; upstream bounds reads in its SessionDB read pool instead. Verified: test-gate (ACE-AI) pytest tests/test_web_server_sessiondb_eventloop.py tests/scripts/test_preyield_permit_release.py tests/test_tui_gateway_ws.py tests/tui_gateway/test_ws_keepalive.py -> 85 passed. ruff --select F on the touched files: no new findings vs origin/main.
|
🤖 merged-by: daedalus-opus · lane: t_f201acde · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: fork-PR audit DROP (Ace ruling 1A, campaign t_03e35f0e, card t_7c17872a): revert-#215+#441; PR CI green on head; conflict-free vs fork/main + sibling reverts (merge-tree chain) |
This was referenced Sep 26, 2026
audit(scripts_misc): batched fork-PR audit reverts — 5 PRs (#1170, #1169, #1180, #1167, #1168)
#1229
Merged
Collaborator
Author
|
Superseded by batched PR #1230 (card t_7c5e08a5). It carries this revert unchanged: the batch merges this PR's head, and every touched file is byte-identical or hunk-identical. Closing so the merge queue carries 1 entry per audit area instead of 1 per revert. The branch is kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-PR audit UNRESOLVED ruling: DROP #215 + #441 (the re-land), reverted as ONE unit. Card t_7c17872a (from t_63023f77; rulings doc PR #1186).
What gets removed:
hermes_cli/session_db_heavy_gate.py(deleted)tui_gateway/ws.py: the gate import and_dispatch_ws_request. WS requests go back toasyncio.to_thread(server.dispatch, req, transport).tui_gateway/server.py:_SESSION_DB_HEAVY_METHODS,is_session_db_heavy_method,backend_busy_error,handle_request_bound. Thedata=parameter on_errstays becausemethods_prompt.pyandmethods_bot_relay.pynow use it.hermes_cli/web_server.py: the gate import, the 503 shed handler and the/api/statussession_db_heavy_readsfield._session_db_read(heavy=True)goes back to the per-loopasyncio.Semaphore(2)it used before feat(tui_gateway): async-side shared heavy-read bound for session.list (seam a) #215.config_defaults:dashboard.heavy_read_max_concurrencytests/test_web_server_sessiondb_eventloop.pyandtests/scripts/test_preyield_permit_release.py, plus the live-site line inscripts/check_preyield_permit_release.py. The guard sweep still has one live site (gateway/turn_admission.py::TurnAdmission.slot), and that site's named coverage test stays, so the guard is not vacuous.A plain
git revertconflicted (UD on the gate module; UU on config.py, server.py and ws.py). The defaults had moved to config_defaults.py, and the checkout-admission and event_replay code grew around the same hunks. All of these were resolved by hand.Why drop it: 0
session_db_heavy_readlog lines across~/.hermes/logsandprofiles/*/logs(the gate logs any wait of 1 ms or more), so it has never contended under fleet load. It is 473/474 loc across 5 files, and those files conflicted in all 3 upstream syncs. Upstream bounds reads in its SessionDB read pool instead. One caveat: the live/api/statuscounter is auth-gated and was not read.Verification:
test-gate(ACE-AI), running pytest ontests/test_web_server_sessiondb_eventloop.py tests/scripts/test_preyield_permit_release.py tests/test_tui_gateway_ws.py tests/tui_gateway/test_ws_keepalive.py: 85 passedruff --select Fon the touched files: no new findings compared with origin/maingit grepfinds no remaining reference outside docs/ tosession_db_heavy_gate,SessionDBHeavyReadBusy,session_db_heavy_reads,heavy_read_max_concurrency,handle_request_bound,backend_busy_erroror_dispatch_ws_requestNot merged from the worker lane; open for the merge pass.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.