Repository navigation
revert(recap): drop backtick-wrap guard on dead session_recap module (audit DROP nopr:8a8b81638c) - #1193
Closed
Kyzcreig wants to merge 1 commit into
Closed
revert(recap): drop backtick-wrap guard on dead session_recap module (audit DROP nopr:8a8b81638c)#1193Kyzcreig wants to merge 1 commit into
Kyzcreig wants to merge 1 commit into
Conversation
… auto-attach" This reverts commit 8a8b816. Fork-PR audit verdict DROP (row nopr:8a8b81638c, rulings doc docs/plans/fork-pr-audit/UNRESOLVED.md, PR #1186): build_recap, the only public entry of hermes_cli/session_recap.py, has 0 non-test callers on fork main (git grep over *.py/*.ts/*.tsx/*.yaml at 702addb) and on upstream. The guarded path cannot run, so the guard fires 0 by construction. Test-file conflict (parity merge aa27fd8 reshaped the file) resolved by taking main's version and deleting only the two tests 8a8b816 added. Card: t_08d470c3
|
🤖 merged-by: daedalus-opus · lane: t_f201acde · gate: BYPASS: FleetReview paused by Ace 2026-09-22 (state/fleetreview-pause marker present) · why: fork-PR audit DROP (Ace ruling 1A, campaign t_03e35f0e, card t_08d470c3): drop-8a8b81638c-dead-recap-guard; PR CI green on head; conflict-free vs fork/main + sibling reverts (merge-tree chain) |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 26, 2026
Collaborator
Author
|
Superseded by batched PR #1230 (card t_7c5e08a5). It carries this revert unchanged: the batch merges this PR's head, and every touched file is byte-identical or hunk-identical. Closing so the merge queue carries 1 entry per audit area instead of 1 per revert. The branch is kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts 8a8b816 ("fix(recap): backtick-wrap Files touched paths to stop gateway auto-attach").
Fork-PR audit verdict: DROP. Row
nopr:8a8b81638cin docs/plans/fork-pr-audit/UNRESOLVED.md (rulings PR #1186).Why
build_recapis the only public entry ofhermes_cli/session_recap.py. On this base (702addb),git grep -nE "session_recap|build_recap" -- '*.py' '*.ts' '*.tsx' '*.yaml'outsidetests/returns only the module's own lines (docstring, def,__all__). Upstream has 0 callers too.Diff
hermes_cli/session_recap.py: back to", ".join(shown).tests/hermes_cli/test_session_recap.py: the two tests 8a8b816 added are removed. The revert conflicted here because parity merge aa27fd8 reshaped the file. I kept main's version and deleted only those two tests (plus two adjacent blank lines).Verification
test-gate venv/bin/python -m pytest tests/hermes_cli/test_session_recap.py -q→2 passed in 0.72sFollow-up, out of scope here: the module itself is dead code.
Card: t_08d470c3. Do not merge from this lane.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.