Repository navigation
test(tui): settle deferred rows before unmount compensation checks - #695
Merged
Merged
Conversation
Drain React work with act and assert the outgoing row mounted before testing same-layout compensation and stale-width rejection. Preserve all compensation assertions. Verified pristine delayed-scheduler RED at line 544 and repaired GREEN on Linux Node 26.8.2. Unmount-only compensation mutation fails. macOS/Linux TUI checks and Ink typechecks pass with four Vitest workers.
૮ >ﻌ< ა ci reviewran on f55bca5 — test(tui): settle deferred rows before unmount compensation
|
Collaborator
Author
FleetReviewConfidence: 4/5 No actionable findings. FleetReview provenance · models: B=gpt-5.6-sol, C=claude-code-opus-5, F=gpt-5.6-sol, G=grok-4.6 · cost: $2.68 · duration: 8m 05s · rounds: 1 · files examined: 1 |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 14, 2026
This was referenced Sep 14, 2026
Kyzcreig
added a commit
that referenced
this pull request
Sep 27, 2026
Each row gets the measurement the lead lacked, then a README section 2 verdict: DROP 10, KEEP 8, UPSTREAM 4, SUPERSEDED-BY-UPSTREAM 2. 14 slice cards were filed for the rows whose verdict changed. Verified: probes on clean fork 858ee59 and upstream c15ebb1 worktrees with a temp home, read-only state.db/kanban.db queries, log greps, a live CDP repro on Chrome 154, and REST merge-queue job-log counts for #695. Narrow fork tests via test-gate: 175 passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ui-tui/src/__tests__/virtualHistoryOffsetCache.test.tsfails inside the GitHub merge queue, blocking every PR onmain:It is SKIPPED on normal PRs (path filter — most PRs touch no JS/TS) but runs in the merge group, so it only surfaces at merge time. Observed on CI runs
34830183258and34831579810.Root cause
Test-determinism defect, not a production bug. The test raced React's deferred work: on a slower/delayed scheduler the outgoing row had not mounted before the same-layout compensation assertions ran, so
adjustScrollTophad legitimately not fired yet.Fix
Test-only. Drain React work with
actand assert the outgoing row actually mounted before testing same-layout compensation and stale-width rejection.useVirtualHistory.ts(the production hook) is unchanged.Verification
s.adjustScrollTop(h - previousHeight)→void (...)atuseVirtualHistory.ts:531) makes it FAIL at line 569 (1 failed / 16 passed). The test still gates the behavior rather than merely passing.