Conversation
mitchellhenke
approved these changes
Oct 31, 2023
changelog: Internal, Code Quality, Remove unused image assets
aduth
force-pushed
the
aduth-rm-unused-images
branch
from
766d3d8 to
bd5cf54
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes unused images.
Why? To keep set of images concise to those actively used, and to reduce amount of data sent over the wire in deployment image uploads.
Process for this was searching for references in code, then backtracking with
git logto understand introduction and last usage.alert/icon-lock-alert-important.svgcarat-right.svgidv/user-in-person.svgmfa-options/security-key-icon.svgminus.svgpersonal-key/email.svgpersonal-key/warning.svgplus.svgscissors.svgsign-in.svguser.svgwebauthn-verified.svgverified.svg📜 Testing Plan
Verify there are no instances of the removed files.