Merged
Conversation
jmax-gsa
force-pushed
the
LG-7353-personal-key-context
branch
from
6460d44 to
de34c87
Compare
1 task
jmax-gsa
force-pushed
the
LG-7353-personal-key-context
branch
2 times, most recently
from
8b9f8bd to
b71fb73
Compare
- Removed body copy under H1 - Removed H2 "Your personal key" - Updated caption copy to read "Your personal key was generated..." - Removed the previous "Save it. Keep it safe." block from this section - Added new copy ToDo: - Add "What is a personal key?" accordian - Move and change copy/download/print links - Add checkbox - Stretch Continue button
- Moved personal key links into _key partial and un-styled them. - Added "What is a personal key?" accordian - Added acknowledgement checkbox and text - Widened continue
[skip changelog]
Pushing for CI run
Remove <br/> and use margin styling insead.
1 task
aduth
reviewed
Oct 14, 2022
Re-arranged confirmation text per slack discussion.
Moved text for personal key download button to its own string file entry.
aduth
approved these changes
Oct 17, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Left a few comments, but overall LGTM 👍
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Removed personal key confirmation dialog feature flag (the dialog is gone and the flag is now unused). Improved personal key acknowledgment checkbox logging.
Broke it the first time.
aduth
reviewed
Oct 17, 2022
aduth
approved these changes
Oct 18, 2022
app/services/analytics_events.rb
Outdated
| # key creation | ||
| # @param [boolean] checked whether the user checked or un-checked | ||
| # the box with this click | ||
| def personal_key_acknowledgment_toggled(checked:, **extra) |
Contributor
There was a problem hiding this comment.
Most (all?) other "IdV:"-prefixed events also prefix the method name idv_
Suggested change
| def personal_key_acknowledgment_toggled(checked:, **extra) | |
| def idv_personal_key_acknowledgment_toggled(checked:, **extra) |
jmhooper
approved these changes
Oct 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7353
🛠 Summary of changes
Updated UI for personal key creation
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After:
🚀 Notes for Deployment
Include any special instructions for deployment.