Skip to content

LG-10233: Sign in "Use face or touch unlock" page revisions#8741

Merged
aduth merged 7 commits intomainfrom
aduth-lg-10233-ft-sign-in-revisions
Jul 12, 2023
Merged

LG-10233: Sign in "Use face or touch unlock" page revisions#8741
aduth merged 7 commits intomainfrom
aduth-lg-10233-ft-sign-in-revisions

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 10, 2023

🎫 Ticket

LG-10233

🛠 Summary of changes

Updates content and experience for Face or Touch Unlock (and Security Key) authentication during sign-in:

  • Green lock screen goes away, redirects immediately
  • "Remember browser" button shown before authentication
  • New content below spinner ("Authenticating your credentials…")
  • Troubleshooting module on use f/t unlock sign in flow

📜 Testing Plan

  1. Sign in with an account that has Security Key or Face or Touch Unlock configured
  2. Observe updated verification page in sign-in

👀 Screenshots

Authenticator Before After
Security Key Screen Shot 2023-07-10 at 2 17 59 PM Screen Shot 2023-07-10 at 2 17 43 PM
Face or Touch Unlock Screen Shot 2023-07-10 at 2 18 36 PM Screen Shot 2023-07-10 at 2 18 29 PM

changelog: Upcoming Features, Face or Touch Unlock, Revise content for Face or Touch Unlock sign-in authentication
aduth added 2 commits July 11, 2023 09:58
changelog: Upcoming Features, Face or Touch Unlock, Improve automated testing for WebAuthn authentication
@aduth aduth marked this pull request as ready for review July 12, 2023 12:23
@aduth aduth requested a review from a team July 12, 2023 12:23
@aduth
Copy link
Contributor Author

aduth commented Jul 12, 2023

Marking this ready to review.

Regarding original draft comments:

Blocked by availability of new help center content

To unblock, I removed the help center link in 02c631d. We'll want to add it back when the help center content is published (tracked in LG-10200). If that's complete before end-of-sprint, I'll do a follow-on pull request, otherwise track as a new ticket.

Will plan to split out refactor for improved testability of webauthn verification behavior (i.e. submit after complete)

This is drafted at #8753, but I'll plan to finish that as a follow-on rather than splitting out.

@aduth aduth merged commit cc86f40 into main Jul 12, 2023
@aduth aduth deleted the aduth-lg-10233-ft-sign-in-revisions branch July 12, 2023 15:36
@zachmargolis zachmargolis mentioned this pull request Jul 12, 2023
@aduth aduth mentioned this pull request Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants