Update phonelib dependencies to add support for newer area codes#8932
Merged
mitchellhenke merged 2 commits intomainfrom Aug 3, 2023
Merged
Update phonelib dependencies to add support for newer area codes#8932mitchellhenke merged 2 commits intomainfrom
mitchellhenke merged 2 commits intomainfrom
Conversation
mdiarra3
approved these changes
Aug 3, 2023
Contributor
|
IS this one of the libraries we should look into continuously updating somehow? |
changelog: Bug Fixes, Phone Number Support, Update dependencies to improve phone number validation
mitchellhenke
force-pushed
the
mitchellhenke/update-phonelibs
branch
from
a5cca95 to
efa5493
Compare
mitchellhenke
force-pushed
the
mitchellhenke/update-phonelibs
branch
from
8133386 to
89a6f1b
Compare
mitchellhenke
pushed a commit
that referenced
this pull request
Aug 3, 2023
* Update phonelib dependencies to add support for newer area codes changelog: Bug Fixes, Phone Number Support, Update dependencies to improve phone number validation * fix specs
aduth
reviewed
Aug 3, 2023
|
|
||
| it 'uses the user phone number as the initial phone value' do | ||
| expect(subject.phone).to eq('+1 787 234 5678') | ||
| expect(subject.phone).to eq('+1 787-234-5678') |
Contributor
There was a problem hiding this comment.
Interested by the formatting changes; this won't cause any downstream issues will it?
Contributor
Author
There was a problem hiding this comment.
This occurred to me too, and I didn't think it would. Phone fingerprints should be using a standard format (e164) and any comparisons format it prior to evaluating like here
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
We received reports that valid US phone numbers were being rejected, and it is in part due to outdated phone validation libraries. This PR updates them.