Merged
Conversation
changelog: Bug Fixes, Asset Compilation, Delete invalid symlinks referencing identity-idp-config
* Remove unused re-authentication controller routes changelog: Internal, Maintenance, Remove unused re-authentication controller routes * remove specs * remove unused session attribute * remove unused tracker method * remove unused template and content Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* changelog: User-Facing Improvements, Webauthn platform, update account creation text * remove test check * fix tests * lint and add additional tests for webauthn setup page * LG-10231: address comments around controller and spec behavior * fix rubocop * address comment * add spec, update spacing
* Fix current path detection for locale URL parameter changelog: Bug Fixes, Localization, Fix tab navigation not showing selected tab in specific parameter combinations * Simple is good * Use ApplicationController for route definitions
* LG-10126: WIP * LG-10126: pull in dependency. * LG-10126: WIP, test etc. * LG-10126: WIP, test etc. * LG-10126: test update. * LG-10126: notification message. * LG-10126: perform later * LG-10126: pass in id. * LG-10126: linter. changelog: In-Person Proofing: send sms notification when proofing result is available. * LG-10126: minor fix. * LG-10126: linter. changelog: User-Facing Improvements, In-Person Proofing, send sms notification when enrollment status is available. * changelog: User-Facing Improvements, In person Proofing, Send sms notification when enrollment status is available (LG-10126) * LG-10126: address comment. * LG-10126: address comment. * LG-10126: lint. * LG-10126: address comment. * LG-10126: build error and comment. * LG-10126: address comment. * LG-10126: address comment. * LG-10126: address comment. * LG-10126: address comment. * LG-10126: use before_save * LG-10126: traits for association * LG-10126: traits for association * LG-10126: address comment. * LG-10126: address comment. * LG-10126: address comment. * LG-10126: address comment. * LG-10126: triggering when set expired from USPS request error. * LG-10126: accidental change. * LG-10126: test expired status. * LG-10126: no sms for expired. * LG-10126: revert. * LG-10126: minor change.
Renamed analytics event Was `doc_auth_upload_submitted`, is now `doc_auth_hybrid_handoff` changelog: Internal,IdV events,Renamed upload events to hybrid handoff for clarity.
) * Separate OpenID Connect Authorization Request and Handoff Logging changelog: Improvements, Logging, Separate OpenID Connect Authorization Request and Handoff Logging * remove attributes * Update app/controllers/openid_connect/authorization_controller.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * inline analytics call Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…re (#8799) * Remove full_width on personal key continue button * changelog: User-Facing Improvements, Identity Verification, Change continue button on personal key page
* Add new feature flag for SSN controller * Delete unused view * Set up new route, controller, view for In-Per SSN * Set up new controller for In Person SSN * updated feature flag name * Update route, templates * Update current step so step indicator is accurate * Fix linter issues * Changed path of files to change route * Update new route name to be more verbose * Modified rediects, update route alias, removed unused code * Modified route, moved files, updated VerifyInfo show to link to SSN page * Add feature and controller specs for idv ipp ssn * fix linter * add more ipp ssn feature specs * Add threatmetrix specs in, format erb file * changelog: User-Facing Improvements, In-person proofing, created a new route-controller-view for IPP ssn step outside of FSM * Remove should_render_threatmetrix_js and tests, not used in fsm ssn so not going to add in non fsm * Delete unused before action * update in_person/ssn_cont specs * Added before action to ipp ssn controller * delete before action * updated click_idv_update method
changelog: Internal, Code Quality, Convert JavaScript to TypeScript
* Fix tab navigation current path detection for non-GET request changelog: Bug Fixes, Localization, Fix tab navigation not showing selected tab in specific parameter combinations * Add specs * Bump CodeClimate
* LG-10214 Fix Suspended User Create Account Email send changelog: User-Facing Improvements, Suspension, Add email send on create account
* update copy for when platform auth device is already registered * update copy for when verification fails * normalize keys * add error for when user fails at account setup * add link functionality in form error message, fix `link_html` key * add `in_mfa_selection_flow` conditional for error display * update spanish and french text for general errors * changelog: User-facing Improvements, Face or touch unlock, update copy for face or touch unlock error messages * fix lint error * remove leftover method * make tests pass * make small edit for test setup * change `link_html` -> `link` variable * make normalize error * fix all keys * add test for new if logic * make test pass
* Refactor references to platform authenticator param * LG-9483: Filter WebAuthn verification credential by attachment changelog: Upcoming Features, Face or Touch Unlock, Filter WebAuthn authenticators by requested attachment
aduth
requested review from
ThatSpaceGuy,
dawei-nava,
gina-yamada,
jmax-gsa,
jmdembe,
kbighorse,
mdiarra3,
mitchellhenke and
zachmargolis
jmdembe
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features