Separate OpenID Connect Authorization Request and Handoff Logging#8798
Merged
mitchellhenke merged 4 commits intomainfrom Jul 18, 2023
Merged
Conversation
Contributor
|
What if we added a |
Contributor
Author
I think the issue is it loses the |
changelog: Improvements, Logging, Separate OpenID Connect Authorization Request and Handoff Logging
mitchellhenke
force-pushed
the
mitchellhenke/separate-oidc-request-handoff-events
branch
from
d44e93d to
da7ff19
Compare
Contributor
chatted in Slack, I agree things would be much simpler overall with two events, especially considering the mess we had to go through to log |
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
deleted the
mitchellhenke/separate-oidc-request-handoff-events
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Currently we do not log successful OIDC auth requests when they are not ultimately going to redirect. This was changed in #6942, so this maintains that by splitting the events and ensuring we always log the request when we get it.
I'm not 100% happy with this, but want to get CI going