Skip to content

LG-9483: Filter WebAuthn verification credential by attachment#8795

Merged
aduth merged 2 commits intomainfrom
aduth-lg-9483-multi-webauthn-prompt
Jul 19, 2023
Merged

LG-9483: Filter WebAuthn verification credential by attachment#8795
aduth merged 2 commits intomainfrom
aduth-lg-9483-multi-webauthn-prompt

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 18, 2023

🎫 Ticket

LG-9483

🛠 Summary of changes

Fixes an issue where a user with multiple WebAuthn configurations (both platform and non-platform) would be prompted for any of their authenticators, regardless of the verification flow, resulting in potentially-confusing scenarios where the user could be prompted for their platform authenticator when trying to use a security key.

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Create an account
  3. Add "Security Key" and "Face or Touch Unlock" during MFA setup
  4. Once you reach account dashboard, click "Forget all browsers" in sidebar and confirm prompt
  5. Sign out
  6. Sign in
  7. Click "Use face or touch unlock" or "Use security key", depending which method you're prompted for
  8. Observe that the browser dialog to use your authenticator corresponds to the expected authenticator for security key or face or touch unlock
  9. Cancel prompt
  10. Click "Choose another authentication method"
  11. Choose the other WebAuthn authenticator method
  12. Click Continue
  13. Repeat Steps 7 and 8

👀 Screenshots

Authenticator Before After
Security Key image image
Face or touch unlock image image

aduth added 2 commits July 18, 2023 09:03
changelog: Upcoming Features, Face or Touch Unlock, Filter WebAuthn authenticators by requested attachment
@aduth aduth requested a review from a team July 18, 2023 13:18
@aduth aduth merged commit 0559a02 into main Jul 19, 2023
@aduth aduth deleted the aduth-lg-9483-multi-webauthn-prompt branch July 19, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants