Jmax/lg 10018 rename analytics doc auth upload#8784
Merged
Conversation
Was `doc_auth_upload_submitted`, is now `doc_auth_hybrid_handoff`
changelog: Internal,IdV events,Renamed upload events to hybrid handoff for clarity.
jmax-gsa
force-pushed
the
jmax/LG-10018-rename-analytics-doc-auth-upload
branch
from
adba25e to
39b9019
Compare
(botched a merge)
soniaconnolly
approved these changes
Jul 14, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM, aside from a stray merge artifact.
app/services/analytics_events.rb
Outdated
| track_event('IdV: doc auth upload visited', **extra) | ||
| end | ||
|
|
||
| # @identity.idp.previous_event_name IdV: doc auth optional verify_wait submitted |
Contributor
There was a problem hiding this comment.
I removed this line in a recent PR. It must have crept back in during a merge and needs to be removed again. I looked into the history, and as far as I can tell, there is no association between verify_wait and verify_proofing_results.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.