Skip to content

Add temporary redirect for WebAuthn error page#8773

Merged
aduth merged 1 commit intomainfrom
aduth-restore-webauthn-error-route
Jul 13, 2023
Merged

Add temporary redirect for WebAuthn error page#8773
aduth merged 1 commit intomainfrom
aduth-restore-webauthn-error-route

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jul 13, 2023

🛠 Summary of changes

Adds a redirect route for the error page removed in #8764, as a temporary solution to avoid potential issues during deployment.

See: #8764 (comment)

📜 Testing Plan

$ curl -I --silent http://localhost:3000/login/two_factor/webauthn_error | grep Location 
Location: http://localhost:3000/login/two_factor/webauthn

changelog: Upcoming Features, Face or Touch Unlock, Remove unnecessary feature detection for WebAuthn
@aduth aduth requested a review from a team July 13, 2023 15:49
Copy link
Contributor

@kevinsmaster5 kevinsmaster5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@aduth aduth merged commit a9c3096 into main Jul 13, 2023
@aduth aduth deleted the aduth-restore-webauthn-error-route branch July 13, 2023 17:53
aduth added a commit that referenced this pull request Jul 13, 2023
aduth added a commit that referenced this pull request Jul 18, 2023
@aduth aduth mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants