Merged
Conversation
* add outage to all post FSM controllers changelog: Internal, Identity Verification, add outage actions to post-FSM controllers * session keys not used - vendor_outage_redirect_from_idv and vendor_outage_redirect * check_for_outage must occur after authentication is confirmed * before_action to be declare in doc_auth controller since removed from concern * happy linting * appears to be unused lingering code * happy linting * add outageconcern to missing controllers * fix typo * no show controller remove outage concern before_action * specify flow session due to in_person flow having flow_session override :eyes: #8517 (comment) Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * mimic flow_session method with default {} * happy linting --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Looks like this endpoint was removed in #8377, and I'm seeing 404s in our logs from users still making this API call. [skip changelog]
* Remove old UploadStep and specs * Remove UploadStep from DocAuthFlow * Don't set UploadStep complete/incomplete * Remove idv_doc_auth_upload_step spec helper and usage * Remove doc_auth_hybrid_handoff_controller_enabled feature flag And fix issue in AgreementStep with redirects * Replace references to upload_step path in outage spec * Remove step_count from upload analytics in analytics_spec * Remove unused FSM view templates * Stop expecting flow_path in upload visited analytics * Remove feature flag that crept in when merging main * Give LinkSent phone_for_mobile_flow via idv_session, not flow_session Both are already being set, so this will not cause a problem in the 50/50 state. * Remove remaining references to UploadStep changelog: Internal, Identity Verification, Delete now-unused UploadStep and related code --------- Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
* do not update verified_at when activating a profile due to a password reset [skip changelog] * happy linting * keep test checks from password_reset of unverified profile in test for an already verified profile * udpate activate signature style to symbol
…tive session (#8521) * Update session timeout spec to actually exercise timeout * Handle 401 response from server for session status Warden will automatically set a response header 401 if the request includes a cookie for an expired session. Because our request utility throws on non-200s, we need to catch the error. * Unset timeout in status response if inactive * Add test case for 401 server response * Offset by timeout_in * Use current main behavior for forcing timeout * Handle unauthorized response consistently * changelog: Bug Fixes, Session Timeout, Improve consistency of session timeout handling * Upgrade TypeScript to resolve typecheck errors * Explicitly list generic parameter variations in overload * Update timeout type to reflect current active endpoint * Revert "Update timeout type to reflect current active endpoint" This reverts commit fd2d313.
… the error (#8525) * change `invalid_phone_number` value * add string for international phone number error * add strings for valid phone number errors * Add capability to pass two strings * logic to toggle valid number by location changelog: Improvements, accessibility, phone number validity error does not describe how to correct the error * WIP fix ts tests to update functionality * add phone number spec for us number * remove examples from invalid phone number message * update tests * try fixing test again * WIP: refactor for regressed behavior * Finish re-working phone input component * fix code for repitition * fix ts test * rename element variables, add test for international number error
changelog: Internal, Telephony, Remove MX from Sender ID countries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
-Accessibility: Phone number validity error does not describe how to correct the error (#8525)
Bug Fixes
Internal