LG-10029: verified_at not updated during password reset#8546
Merged
Conversation
… reset [skip changelog]
…r an already verified profile
amirbey
changed the title
amirbey
changed the title
soniaconnolly
approved these changes
Jun 7, 2023
| @@ -46,18 +46,22 @@ def pending_reasons | |||
| end | |||
|
|
|||
| # rubocop:disable Rails/SkipsModelValidations | |||
Contributor
There was a problem hiding this comment.
Tangential to this PR since it was here already. Does this mean validations are enabled or disabled, and is that the way we want it?
| deactivation_reason: nil, | ||
| ) | ||
| activate | ||
| activate(reason_deactivated: :password_reset) |
Contributor
There was a problem hiding this comment.
I like this pattern! Then we can coalesce the behavior for different reasons inside activate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10029
🛠 Summary of changes
Added an optional argument to the Profile#activate method which is used to detail why the account is being activated; and, if it is due to a passoword reset, then verified_at is not set during profile update.
📜 Testing Plan
Added an automated test to check this in profile_spec.rb