Remove call to document_capture_errors endpoint#8540
Merged
Conversation
Looks like this endpoint was removed in #8377, and I'm seeing 404s in our logs from users still making this API call. [skip changelog]
matthinz
commented
Jun 6, 2023
| }), | ||
| ]); | ||
| function skipAttention() { | ||
| trackEvent('IdV: barcode warning continue clicked'); |
Contributor
Author
There was a problem hiding this comment.
(trackEvent is no longer async, so this whole function can be made non-async)
Contributor
There was a problem hiding this comment.
Can we also make the SpinnerButton that calls it a regular Button now as well, @matthinz ?
Contributor
Author
There was a problem hiding this comment.
Sure thing, I'll follow up with a new PR
matthinz
added a commit
that referenced
this pull request
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like this endpoint was removed in #8377, and I'm seeing 404s in our logs from users still making this API call.
[skip changelog]