Merged
Conversation
changelog: User-Facing Improvement, IdV Warning Page, updating content on phone verification warning page * Updating locales * Adding spec for cancel link * Update spec/features/idv/steps/phone_step_spec.rb --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Clean up leftover code customizing the message for GPO flow Do not show verify phone success banner for gpo flow on Enter Password page changelog: User-facing improvements, Identity Verification, Clearer success banner on Enter Password page * Rename info_verified translation key to phone_verified
* LG-8115: don't require any auth headers for DDP. [skip changelog] * Rename Proofing::LexisNexis::Request#send to Proofing::LexisNexis::Request#send_request This is to avoid overriding Object#send and allow me to test the ddp request headers (private method call). * refactor to more clearly have authenticated requests, or not * test the inclusion of hmac token for IV/PF
…8365) * rename retro_fail_enrollment method * use present? & get rid of unneeded comment * remove redundant expectation * add more rigorous email testing * consistently send emails before logging about them changelog: Internal, Refactor, Refactor GetUspsProofingResultsJob & spec
* Switch to more flexible type matcher because timestamps will always drift changelog: Internal, Tooling, Add script to streamline data pulls
* initial commit with compare_yaml script * one version of mapping the data by issuer * code to find diffs * refactor diff logic into its own method and add diff to initialize * reset db at beginning and return all values * clean up iaa_orders diff * get iaa_order diff grouped without extra method * fix rubocop errors in script * Update app/services/service_provider_seeder.rb Co-authored-by: Michael <107054114+mmagsa@users.noreply.github.com> * remove compare_yaml script because its getting moved to idp-config * Add changelog changelog: Internal, PSE integration script, LG-8917 * revert gitignore --------- Co-authored-by: Michael <107054114+mmagsa@users.noreply.github.com>
…ller (#8367) * Add csp overrides before action for ThreatMetrix to SsnController This before action is needed to allow ThreatMetrix to load in browsers that respect Content Security Policies. It was part of the Flow State Machine but not clearly part of the SSN step. changelog: Bug Fixes, Identity Verification, include Content Security Policy overrides for ThreatMetrix in SSN step * Add controller test that checks csp overrides This makes it more explicit that the overrides are required for the SSN step. --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov>
* Rename spec file to match the file under test * Proof state ID address against AAMVA and LN ...when the user is going through double address verification and has a different address listed on their state ID than where they reside. changelog: Upcoming Features, Double address verification, Begin proofing state ID address * Use string instead of boolean * Fix lint and spec failures * Pull resolution proofing into a new module * Reduce resolution logic to only one address * Fix merge conflicts * Fix lint failures * Revert unnecessary change This was necessary with how the previous version was structured but it's not anymore * Begin using state_id_state field * Pass DAV flag into resolution proofing job * Rename proofer to indicate its progressive nature * Correctly calculate DAV flag for IPP * Fix indentation * Fix merge conflicts * Fix lint failures * Fix spec failure * Pull logging and proofing component into job * Make ProgressiveProofer stateless * Simplify PR changes * Add progressive proofer spec skeleton * Begin fleshing out progressive proofer specs * Fix analytics feature spec * test progressive proofer * update specs for verify_info_controller * update specs * respond to feedback * fix errors related to drivers_license_info_matches * begin responding to feedback * fix broken analytics specs * fix lint * expand progressive proofer tests, particularly threatmetrix tests * add tests to progressive proofer spec * fix specs and identity_doc variables * fix tests * Apply residential address only * fix tests to match dav expectations * remove nil check for pii in progressive proofer * Setup same address spec context * Remove residential code for now * Add residential checks; todo: update result adjudicator * ProgressiveProofer residential check included * move IV proof of res address before IV proof of id address * WIP naming refactor and logic for lexisnexis failing res address * share tests for rubber duck * Fix syntax error * work to support residential and id addresses * support double address verification when id and residential address are the same * update resolution proofing job * changelog: Upcoming Features, In-person proofing, verify res address with LexisNexis * refactor out_of_aamva_jurisdiction_result guard statement * refactor progressive proofer conditional check and naming * fix bug for pre-DAV users w same id & res address * clarify vendor names and comments * revert changes to vendor name * improve specs for same_address_as_id non-dav bug * decrease coupling of result adjudicator & progressive proofer * tweak pii transformation --------- Co-authored-by: Sheldon Bachstein <sheldon.bachstein@gsa.gov> Co-authored-by: Matt Gardner <wilburnforce@gmail.com>
* Add doc_auth_link_sent_controller_enabled feature flag * Initial LinkSentController, controller spec, routes * Add template, fix cancel action, add feature spec * Add LinkSentStep call code And change mark_step_complete methods * Clean up tests Use clear_and_fill_in feature spec helper * Put :phone_for_mobile_flow in flow_session idv_session is different inside and outside the FSM, so use the flow session to transmit :phone_for_mobile_flow from UploadStep to LinkSentController. This can be put in idv_session when the UploadStep is removed from FSM. * Add 404 before action if feature flag disabled * Fix feature spec, add polling spec * Add flow_session to show params * Lint, and add flow_path back to analytics * Add step indicator * Remove unneeded combined hybrid handoff context * Redirect from UploadStep to LinkSentController (feature flagged) Now we can test with polling enabled and make sure the Continue button isn't shown. * Add step_url to back action to avoid js errors on refresh step_url has to be a symbol, not a url When not included, _back.html.erb defaults to referrer, which can null and cause an error on a direct visit to the page. * Redirect to LinkSent from SsnController... if there is no PII and flow_path is set to hybrid (and feature flag is enabled). Otherwise still redirect to idv_doc_auth_url and let the FSM figure out where to go. * Ensure Continue button is not shown in LinkSent page, in hybrid_mobile spec When document capture is not being done in a separate browser window, LinkSent shows a warning not to leave the page, which was causing a problem in a downstream spec. Instead of trying to test polling in isolation, add one line to an existing full spec. Changelog: Internal, Identity Verification dismantle Flow State Machine, new LinkSentController (feature flagged) * Add hybrid flow spec with link_sent feature flag enabled * Add extend_meta_refresh before_action from doc_auth_controller * Call LinkSentController#update when hybrid flow is complete * Add code that puts captured pii in session This needs to be refactored into a concern or class since the same code is also used by the DocumentCaptureControllers --------- Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
changelog: Internal, Tooling, Add script to streamline data pulls
zachmargolis
approved these changes
May 10, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! The release notes:
Double address verification: Begin
could probably use some additional expansion/details
soniaconnolly
commented
May 10, 2023
Contributor
Author
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Good catch on: "Double address verification: Begin" could probably use some additional expansion/details.
The rest of the description was on the next line. Fixed in PR comment and release notes.
changelog: User-facing improvements, In-person Proofing, re-add the secondary ID instructions to web & email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features