Merged
Conversation
soniaconnolly
added
status - work in progress
status - do not merge
and removed
status - work in progress
labels
soniaconnolly
force-pushed
the
sonia-lg-9568-link-sent-controller
branch
3 times, most recently
from
52ce5be to
c8a55e5
Compare
And change mark_step_complete methods Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
Use clear_and_fill_in feature spec helper
idv_session is different inside and outside the FSM, so use the flow session to transmit :phone_for_mobile_flow from UploadStep to LinkSentController. This can be put in idv_session when the UploadStep is removed from FSM.
It gets a javascript error relating to explicitly navigating to the new page.
Now we can test with polling enabled and make sure the Continue button isn't shown.
step_url has to be a symbol, not a url When not included, _back.html.erb defaults to referrer, which can null and cause an error on a direct visit to the page. Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
The error about leaving the page is showing up in unrelated specs. See if this fixes that.
if there is no PII and flow_path is set to hybrid (and feature flag is enabled). Otherwise still redirect to idv_doc_auth_url and let the FSM figure out where to go.
…e spec When document capture is not being done in a separate browser window, LinkSent shows a warning not to leave the page, which was causing a problem in a downstream spec. Instead of trying to test polling in isolation, add one line to an existing full spec. Co-authored-by: John Maxwell <john.maxwell@gsa.gov>
soniaconnolly
force-pushed
the
sonia-lg-9568-link-sent-controller
branch
from
c8a55e5 to
758f8d7
Compare
matthinz
reviewed
May 5, 2023
This needs to be refactored into a concern or class since the same code is also used by the DocumentCaptureControllers
jmhooper
approved these changes
May 10, 2023
eric-gade
approved these changes
May 10, 2023
This was referenced May 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9494
🛠 Summary of changes
New LinkSentController behind feature flag will replace LinkSentStep.
Note: Continue button is visible when link sent polling is off, which is only in tests.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
/verify/link_sent(withoutdoc_auth)/test/telephonyto open the texted link in a different browser. (If you open it in another window of the same browser, it logs you out, last time I tried it.)👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
New view: