LG-8917 Compare results of data seeder with new serialized yaml #8359
Merged
LG-8917 Compare results of data seeder with new serialized yaml #8359
Conversation
Jeremy1026
approved these changes
May 9, 2023
Contributor
|
Lint is mad, but the code itself looks good. Looks like lint isn't happy with your indentation, which I think was set to 4 spaces instead of 2. |
mmagsa
reviewed
May 9, 2023
mmagsa
reviewed
May 9, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
@mitchellhenke I rebased and that fixed the security issue but now I'm getting an error in one of the specs.. I'm not sure how the minor changes made here would effect that test
|
Contributor
That seems like a flaky test from #8345 (cc @zachmargolis) |
zachmargolis
reviewed
May 9, 2023
Co-authored-by: Michael <107054114+mmagsa@users.noreply.github.com>
changelog: Internal, PSE integration script, LG-8917
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8917
🛠 Summary of changes
This is part of the epic for the work around creating a script for PSE's to generate YAML that is easier, cleaner and more consistent.
These are some very minor changes to the seeders so that we can run the compare_yaml.rb script created in the PR here
Also a gitignore update because the serialized directory needs to be copied over from the config in order to run the script and I don't want it to get accidentally commited.
📜 Testing Plan
If you want to test the code for grouping the iaa_order diffs, you can add a binding.pry under line 30 checking for
value.length > 1and update some attributes invalueto see that the diff is returned without multiple entries for the same account.