Skip to content

LG-8917 Compare results of data seeder with new serialized yaml #8359

Merged
nprimak merged 12 commits intomainfrom
np/LG-8917
May 10, 2023
Merged

LG-8917 Compare results of data seeder with new serialized yaml #8359
nprimak merged 12 commits intomainfrom
np/LG-8917

Conversation

@nprimak
Copy link
Contributor

@nprimak nprimak commented May 8, 2023

🎫 Ticket

LG-8917

🛠 Summary of changes

This is part of the epic for the work around creating a script for PSE's to generate YAML that is easier, cleaner and more consistent.

These are some very minor changes to the seeders so that we can run the compare_yaml.rb script created in the PR here

Also a gitignore update because the serialized directory needs to be copied over from the config in order to run the script and I don't want it to get accidentally commited.

📜 Testing Plan

If you want to test the code for grouping the iaa_order diffs, you can add a binding.pry under line 30 checking for value.length > 1 and update some attributes in value to see that the diff is returned without multiple entries for the same account.

@nprimak nprimak requested review from Sgtpluck and mitchellhenke May 8, 2023 21:14
@Jeremy1026
Copy link
Contributor

Lint is mad, but the code itself looks good. Looks like lint isn't happy with your indentation, which I think was set to 4 spaces instead of 2.

@nprimak

This comment was marked as resolved.

@mitchellhenke

This comment was marked as resolved.

@nprimak
Copy link
Contributor Author

nprimak commented May 9, 2023

@mitchellhenke I rebased and that fixed the security issue but now I'm getting an error in one of the specs.. I'm not sure how the minor changes made here would effect that test

DataPull DataPull::EmailLookup#run loads email addresses for the user

@mitchellhenke
Copy link
Contributor

@mitchellhenke I rebased and that fixed the security issue but now I'm getting an error in one of the specs.. I'm not sure how the minor changes made here would effect that test

DataPull DataPull::EmailLookup#run loads email addresses for the user

That seems like a flaky test from #8345 (cc @zachmargolis)

@nprimak nprimak merged commit 05f601d into main May 10, 2023
@nprimak nprimak deleted the np/LG-8917 branch May 10, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants