LG-8115: don't require any auth headers for DDP.#8358
Conversation
[skip changelog]
…quest#send_request This is to avoid overriding Object#send and allow me to test the ddp request headers (private method call).
| end | ||
|
|
||
| it 'does not include an Authorization header' do | ||
| expect(subject.send(:build_request_headers)['Authorization']).to be_nil |
There was a problem hiding this comment.
To be able to call the private method Proofing::LexisNexis::Ddp::VerificationRequest#build_request_headers, I needed to rename Proofing::LexisNexis::Request#send to stop overriding Object#send
| end | ||
|
|
||
| def send | ||
| def send_request |
There was a problem hiding this comment.
To be able to call the private method Proofing::LexisNexis::Ddp::VerificationRequest#build_request_headers, I needed to rename Proofing::LexisNexis::Request#send to stop overriding Object#send
| end | ||
|
|
||
| it 'does not include an Authorization header' do | ||
| expect(subject.send(:build_request_headers)['Authorization']).to be_nil |
There was a problem hiding this comment.
I'm a little confused here -- shouldn't the header be the signed hmac value if the feature flat is set to true?
There was a problem hiding this comment.
This is for the DDP proofer - it includes the api key in the body of the message, so we don't need, and thus are explicitly removing, the auth header.
3 participants
🎫 Ticket
LG-8115
🛠 Summary of changes
The ThreatMetrix DDP API does not require any auth headers (basic or hmac) so let's stop sending them.