Change re-authentication to only require a second factor rather than password and second factor and require authentication for more account management actions#8037
Merged
mitchellhenke merged 11 commits intomainfrom Mar 24, 2023
Conversation
zachmargolis
approved these changes
Mar 21, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM, small questions, no big objections
aduth
reviewed
Mar 21, 2023
mitchellhenke
force-pushed
the
mitchellhenke/reauthentication-required-2
branch
4 times, most recently
from
390f05d to
ae66066
Compare
aduth
approved these changes
Mar 23, 2023
Contributor
There was a problem hiding this comment.
I know it's a hold-over, but... is this value used for anything?
Contributor
Author
There was a problem hiding this comment.
Not that I can find. It's added in the original PR for this behavior, but I can't see that it's used for anything in it: https://github.com/18F/identity-idp/pull/507/files#diff-21b23b276c9228c6a6d1393e4f1ef35a90a49d7c9776cae93f395381990dea36R5
mitchellhenke
force-pushed
the
mitchellhenke/reauthentication-required-2
branch
from
4cef28b to
b68b10c
Compare
added 10 commits
March 24, 2023 15:18
…password and second factor and require authentication for more account management actions changelog: User-Facing Improvements, Authentication, Change re-authentication to only require a second factor rather than password and second factor and require authentication for more account management actions
…tion if configured
mitchellhenke
force-pushed
the
mitchellhenke/reauthentication-required-2
branch
from
b68b10c to
5e5fb18
Compare
Merged
This was referenced Apr 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Follow-up to #8031
This PR intends to simplify some of the re-authentication requirements and improve account security within the IDP in two ways:
It is behind a feature flag where the behavior should not change when it is disabled and it should be backwards and forwards compatible.