Require recent authentication before deleting account#9183
Merged
mitchellhenke merged 2 commits intomainfrom Sep 14, 2023
Merged
Conversation
zachmargolis
approved these changes
Sep 14, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
do we want to add a expect(...).to have_before_action kind of spec?
changelog: User-Facing Improvements, Account Deletion, Require recent authentication before deleting account
mitchellhenke
force-pushed
the
mitchellhenke/require-recent-authentication-for-deleting-account
branch
from
ab50182 to
4aa7c01
Compare
Contributor
Author
Yes, added in 4aa7c01! |
mitchellhenke
force-pushed
the
mitchellhenke/require-recent-authentication-for-deleting-account
branch
from
4aa7c01 to
7dfc1bf
Compare
zachmargolis
approved these changes
Sep 14, 2023
mitchellhenke
deleted the
mitchellhenke/require-recent-authentication-for-deleting-account
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
A follow-up to to complete the missing account management actions described in this SBAR. Most of these were done in #8037, but account deletion was missed.