Clean up feature flag for second factor reauthentication#8707
Clean up feature flag for second factor reauthentication#8707mitchellhenke merged 2 commits intomainfrom
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/remove-reauthentication-2fa-feature-flag
branch
from
b5448b7 to
3c6127c
Compare
There was a problem hiding this comment.
This is the only place this is assigned, but it's still referenced in a view? 🤔
There was a problem hiding this comment.
Yeah, this controller has been re-used in other ways where it's not changing factors and the change_factor does not exist. It's also not translated and the content should be re-written to be more generic.
There was a problem hiding this comment.
https://gsa-tts.slack.com/archives/CEUQ9FXNJ/p1643994476402979 is a Slack thread that discusses it a bit (with an associated ticket that's linked above that line)
There was a problem hiding this comment.
I'll un-icebox that ticket and get it in front of the team.
There was a problem hiding this comment.
Out of curiosity, was the _2fa suffix added to help with clarity, or just something we added to avoid conflict with the original method name (i.e. we'd want to circle back and rename to drop it)?
Personally I think it's an improvement though 👍
There was a problem hiding this comment.
It was added to differentiate from the previous method (which intended to require both password and 2FA).
I like the idea of keeping it as well for descriptiveness' sake.
There was a problem hiding this comment.
Can this ticket be cancelled?
There was a problem hiding this comment.
I think so, yeah. I can do that.
There was a problem hiding this comment.
The part about the untranslated string can be cancelled, but does the copy on the page still say "sign in with your phone" for all other MFAs? If so then that part of the ticket should stay
There was a problem hiding this comment.
My hope is to remove this page since it'll be unused after this PR
changelog: Internal, Maintenance, Clean up feature flag for second factor reauthentication
mitchellhenke
force-pushed
the
mitchellhenke/remove-reauthentication-2fa-feature-flag
branch
from
4a46d73 to
1b1c49d
Compare
mitchellhenke
deleted the
mitchellhenke/remove-reauthentication-2fa-feature-flag
branch
3 participants
🛠 Summary of changes
This was added in #8037 and has been enabled in the major environments for awhile, so this PR enables it by default and removes the configuration for it.